Open
Conversation
PR Security UpdateAll commits in this PR up to and including 19b4ae3 have been reviewed and marked safe by SDLC security. For any questions, please reach out to #ci-for-external-contributors-collab on Slack. |
bengl
reviewed
May 9, 2025
Contributor
Author
|
So I've split the additions into 2 features, If you don't enable any features you get the basic Rust library. |
Contributor
Author
|
Oh no, I deleted this branch forgetting this was still open here! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is built on top of #10 and #11 so they would need to be merged first for the full diff here to be reduced.
You can see the diff from the previous PR here.
This PR:
wasmfeature so that consumers of the Rust library don't need to bring in all those dependencies if they don't need themtransformfunction toInstrumentationVisitor- this was moved from the test utils withunwrap()removedwasmmodule in the library that is only enabled with the wasm featurewasmmodule, add functions and types that are exposed from wasm via#[wasm_bindgen]InstrumentationVisitorlifetimes had to be removed because they're not supported across rust<->js boundarypackage.jsonYou can
npm install && npm run buildto build the module.You can run
npm testto run a single JavaScript test of the wasm and asserts the output matches what's expected.