feat: Convert windows path to unix path before comparing against ModuleMatcher file_path value.#40
Merged
bizob2828 merged 1 commit intonodejs:mainfrom Mar 6, 2026
Conversation
bizob2828
requested review from
AbhiPrasad,
bengl,
jsumners-nr and
timfish
and removed request for
AbhiPrasad
bizob2828
force-pushed
the
convert-win-paths-to-unix
branch
from
8f966c3 to
48ca1a5
Compare
Qard
approved these changes
Mar 4, 2026
ModuleMatcher file_path value.
bizob2828
force-pushed
the
convert-win-paths-to-unix
branch
from
48ca1a5 to
5c355ba
Compare
jsumners-nr
approved these changes
Mar 4, 2026
Contributor
jsumners-nr
left a comment
jsumners-nr
left a comment
There was a problem hiding this comment.
Looks like code to me.
Contributor
Author
|
@AbhiPrasad @timfish @bengl do you want to take a look at this or are you ok if I merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR converts file_path to unix style which implies the ModuleMatcher configuration is always unix paths. I refactored some of the test harnesses to allow to pass in an alternate file path. I also add both rust and wasm tests around wrapping a method when a windows file path is passed in whereas the configured path is unix style.
This resolves apm-js-collab/tracing-hooks#19