if ssh address is not present, make one from user and IP#2
if ssh address is not present, make one from user and IP#2ogost wants to merge 5 commits intonot-jan:masterfrom
Conversation
|
I hope this time I got it right. |
…er. This is a workaround
| fi | ||
| if [[ "$line" == user:* ]]; then | ||
| local ssh_user=${line#"user:"} | ||
| # ssh_user=${ssh_user##+([[:space::]])} |
There was a problem hiding this comment.
Can you remove the old code comments?
| fi | ||
| done < <(echo "$contents") | ||
| if [[ -z ${ssh_address+x} ]]; then | ||
| ssh_address="${ssh_user// /}@${ssh_host// /}" |
There was a problem hiding this comment.
If ssh:, IP: and user: aren't specified this will effectively disable the empty check in line 39 by setting ssh_address to "@", right?
There was a problem hiding this comment.
Right, I guess I'll have to do something else.
| # Default value for flags | ||
| ssh_flags="${ssh_flags:-}" | ||
|
|
||
| if [[ "$TERM" == "xterm-kitty" ]]; then |
There was a problem hiding this comment.
What does this do? Shouldn't this go into your .bashrc / .zshrc?
There was a problem hiding this comment.
Sorry this wasn't supposed to be in the merge request. This is a personal setting, putting it in .bashrc / .zshrc breaks some other things in my setup. It's the first time I'm trying to do a pull request to a public repo, I guess I will make a branch and make a pull request from there. Sorry for wasting your time. Please cancel this request, I'll try to do it properly next time.
2 participants
If you have passwords stored like this:
then make ssh_address by concatenating @.