fix: ship npm-shrinkwrap.json to eliminate glob@10 deprecation warning#4
Closed
notgitika wants to merge 1 commit into
Closed
fix: ship npm-shrinkwrap.json to eliminate glob@10 deprecation warning#4notgitika wants to merge 1 commit into
notgitika wants to merge 1 commit into
Conversation
…g on install The overrides field only applies when this package is the root of the dependency tree. When users install globally, npm ignores overrides and resolves archiver-utils's glob@^10.0.0 to the deprecated glob@10.5.0. npm-shrinkwrap.json is respected during all install scenarios (global, non-root). This locks glob to 13.0.6, eliminating the warning. Closes aws#1266
github-actions
Bot
added
size/l
Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm-shrinkwrap.jsonwith the published package to lockglobat v13.0.6, preventing the deprecatedglob@10.5.0from being resolved during end-user installsnpm-shrinkwrap.jsonto thefilesarray inpackage.jsonto ensure inclusion in the tarballContext
The existing
overridesfield correctly resolves glob to v13 locally, but npm only applies overrides at the root of the dependency tree. When users runnpm install -g @aws/agentcore@preview, overrides are ignored andarchiver-utils@5.0.2(via@aws-cdk/toolkit-lib→archiver@7.0.1) pulls in the deprecatedglob@10.5.0.npm-shrinkwrap.jsonis the npm-sanctioned mechanism for CLI tools to lock their transitive dependency tree for all install scenarios (global, non-root).Closes aws#1266
Test plan
npm packand verifynpm-shrinkwrap.jsonis included in tarballnode_modules/glob/package.jsonshows version 13.x after install