Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
### Bug Fixes
* [`a9d242b`](https://github.com/npm/cli/commit/a9d242bc4f04440630141743949ddb0d323f90b4) [#9099](https://github.com/npm/cli/pull/9099) include all subcommands on main command help (#9099) (@wraithgar)
* [`29b8407`](https://github.com/npm/cli/commit/29b8407971af1b9a2a3dcdb3849adfa04363fa7f) [#9087](https://github.com/npm/cli/pull/9087) unwrap comments and lines meant for output (#9087) (@wraithgar)
* [`b56986a`](https://github.com/npm/cli/commit/b56986acb0661fba2c80135eff3d140aa659dcf5) [#9095](https://github.com/npm/cli/pull/9095) ls: suppress false UNMET DEPENDENCYs in linked strategy (#9095) (@manzoorwanijk)
* [`b56986a`](https://github.com/npm/cli/commit/b56986acb0661fba2c80135eff3d140aa659dcf5) [#9095](https://github.com/npm/cli/pull/9095) ls: suppress false UNMET dependencies in linked strategy (#9095) (@manzoorwanijk)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one was on purpose?

* [`76c76e5`](https://github.com/npm/cli/commit/76c76e5ad7cc5c7f641a92334b900c9d0c9a3fbd) [#9083](https://github.com/npm/cli/pull/9083) ci: don't error on optional deps in the lockfile (#9083) (@wraithgar)
* [`a29aeee`](https://github.com/npm/cli/commit/a29aeee18f3ddc2348a8e00787d237c874642789) [#9028](https://github.com/npm/cli/pull/9028) arborist: retry bin-links on Windows EPERM (#9028) (@manzoorwanijk)
* [`6565eeb`](https://github.com/npm/cli/commit/6565eeb818494e1feb4e14492804ce936b394b4a) [#9045](https://github.com/npm/cli/pull/9045) bypass packument cache to prevent ETARGET errors after publish (#9045) (@Jadu07)
Expand Down
2 changes: 1 addition & 1 deletion docs/lib/content/configuring-npm/folders.md
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ So, that gets installed at [A].
Since the parent installation of blerg satisfies bar's dependency on `blerg@1.x`, it does not install another copy under [B].

Bar [B] also has dependencies on baz and asdf.
Because it depends on `baz@2.x`, it cannot re-use the `baz@1.2.3` installed in the parent `node_modules` folder [D], and must install its own copy [C].
Because it depends on `baz@2.x`, it cannot reuse the `baz@1.2.3` installed in the parent `node_modules` folder [D], and must install its own copy [C].
In order to minimize duplication, npm hoists dependencies to the top level by default, so asdf is installed under [A].

Underneath bar, the `baz -> quux -> bar` dependency creates a cycle.
Expand Down
2 changes: 1 addition & 1 deletion mock-registry/lib/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ class MockRegistry {
// this requires that mocks not be shared between sub tests but it helps
// find mistakes quicker instead of waiting for the entire test to end
t.afterEach((t) => {
t.strictSame(server.pendingMocks(), [], 'no pending mocks after each')
t.strictSame(server.pendingMocks(), [], 'no pending mocks afterEach')
})
}

Expand Down
2 changes: 1 addition & 1 deletion node_modules/@npmcli/run-script/lib/signal-manager.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const forwardedSignals = [
]

// no-op, this is so receiving the signal doesn't cause us to exit immediately
// instead, we exit after all children have exited when we re-send the signal
// instead, we exit afterAll children have exited when we re-send the signal
// to ourselves. see the catch handler at the bottom of run-script-pkg.js
const handleSignal = signal => {
for (const proc of runningProcs) {
Expand Down
2 changes: 1 addition & 1 deletion node_modules/minizlib/dist/commonjs/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ class ZlibBase extends minipass_1.Minipass {
nativeHandle.close = originalNativeClose;
this.#handle.close = originalClose;
// `_processChunk()` adds an 'error' listener. If we don't remove it
// after each call, these handlers start piling up.
// afterEach call, these handlers start piling up.
this.#handle.removeAllListeners('error');
// make sure OUR error listener is still attached tho
}
Expand Down
2 changes: 1 addition & 1 deletion node_modules/minizlib/dist/esm/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ class ZlibBase extends Minipass {
nativeHandle.close = originalNativeClose;
this.#handle.close = originalClose;
// `_processChunk()` adds an 'error' listener. If we don't remove it
// after each call, these handlers start piling up.
// afterEach call, these handlers start piling up.
this.#handle.removeAllListeners('error');
// make sure OUR error listener is still attached tho
}
Expand Down
2 changes: 1 addition & 1 deletion node_modules/node-gyp/gyp/docs/InputFormatReference.md
Original file line number Diff line number Diff line change
Expand Up @@ -956,7 +956,7 @@ values, depending on the setting of `OS`:
Note that when `OS` is `win`, the `include` for `_win.cc` files is
processed after the `exclude` matching the same pattern, because the
`sources/` list participates in [merging](#Merging) during
[conditional evaluation](#Conditonals) just like any other list
[conditional evaluation](#Conditionals) just like any other list
would. This guarantees that the `_win.cc` files, previously
unconditionally excluded, will be re-included when `OS` is `win`.

Expand Down
4 changes: 2 additions & 2 deletions node_modules/node-gyp/gyp/docs/LanguageSpecification.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ The overall design has the following characteristics:

Some up-front design principles/thoughts/TODOs:

* Re-use keywords consistently.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are dependencies, we should not be changing them.

* Reuse keywords consistently.
* Keywords that allow configuration of a platform-specific concept get
prefixed appropriately:
* Examples: `msvs_disabled_warnings`, `xcode_framework_dirs`
Expand Down Expand Up @@ -209,7 +209,7 @@ Configuration dictionaries may also contain these elements:
Conditionals may appear within any dictionary in a `.gyp` file. There
are two tpes of conditionals, which differ only in the timing of their
processing. `conditions` sections are processed shortly after loading
`.gyp` files, and `target_conditions` sections are processed after all
`.gyp` files, and `target_conditions` sections are processed afterAll
dependencies have been computed.

A conditional section is introduced with a `conditions` or
Expand Down
4 changes: 2 additions & 2 deletions node_modules/node-gyp/gyp/pylib/gyp/generator/msvs.py
Original file line number Diff line number Diff line change
Expand Up @@ -1077,7 +1077,7 @@ def _GenerateMSVSProject(project, options, version, generator_flags):
_AddCopies(actions_to_add, spec)
_WriteMSVSUserFile(project.path, version, spec)

# NOTE: this stanza must appear after all actions have been decided.
# NOTE: this stanza must appear afterAll actions have been decided.
# Don't excluded sources with actions attached, or they won't run.
excluded_sources = _FilterActionsFromExcluded(excluded_sources, actions_to_add)
_ExcludeFilesFromBeingBuilt(p, spec, excluded_sources, excluded_idl, list_excluded)
Expand Down Expand Up @@ -3712,7 +3712,7 @@ def _GenerateMSBuildProject(project, options, version, generator_flags, spec):
_AddActions(actions_to_add, spec, project.build_file)
_AddCopies(actions_to_add, spec)

# NOTE: this stanza must appear after all actions have been decided.
# NOTE: this stanza must appear afterAll actions have been decided.
# Don't excluded sources with actions attached, or they won't run.
excluded_sources = _FilterActionsFromExcluded(excluded_sources, actions_to_add)

Expand Down
2 changes: 1 addition & 1 deletion node_modules/node-gyp/gyp/pylib/gyp/input.py
Original file line number Diff line number Diff line change
Expand Up @@ -1660,7 +1660,7 @@ def __repr__(self):
def FlattenToList(self):
# flat_list is the sorted list of dependencies - actually, the list items
# are the "ref" attributes of DependencyGraphNodes. Every target will
# appear in flat_list after all of its dependencies, and before all of its
# appear in flat_list afterAll of its dependencies, and beforeAll of its
# dependents.
flat_list = OrderedSet()

Expand Down
2 changes: 1 addition & 1 deletion node_modules/postcss-selector-parser/API.md
Original file line number Diff line number Diff line change
Expand Up @@ -655,7 +655,7 @@ Remains `undefined` if there is no attribute value.
Like `node.spaces` with the `before` and `after` values containing the spaces
around the element, the parts of the attribute can also have spaces before
and after them. The for each of `attribute`, `operator`, `value` and
`insensitive` there is corresponding property of the same nam in
`insensitive` there is corresponding property of the same name in
`node.spaces` that has an optional `before` or `after` string containing only
whitespace.

Expand Down
2 changes: 1 addition & 1 deletion node_modules/promise-all-reject-late/test/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const main = () => {
const runTests = () => {
const lateFail = require('../')

t.test('fail only after all promises resolve', t => {
t.test('fail only afterAll promises resolve', t => {
let resolvedSlow = false
const fast = () => Promise.reject('nope')
const slow = () => new Promise(res => setTimeout(res, 100))
Expand Down
6 changes: 3 additions & 3 deletions node_modules/safer-buffer/Porting-Buffer.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ also find calls to deprecated `Buffer()` API. Those rules are included in some p

There is a drawback, though, that it doesn't always
[work correctly](https://github.com/chalker/safer-buffer#why-not-safe-buffer) when `Buffer` is
overriden e.g. with a polyfill, so recommended is a combination of this and some other method
overridden e.g. with a polyfill, so recommended is a combination of this and some other method
described above.

<a id="variant-1"></a>
Expand All @@ -68,7 +68,7 @@ Note that `Buffer.alloc()` is also _faster_ on the current Node.js versions than
Enabling eslint rule [no-buffer-constructor](https://eslint.org/docs/rules/no-buffer-constructor)
or
[node/no-deprecated-api](https://github.com/mysticatea/eslint-plugin-node/blob/master/docs/rules/no-deprecated-api.md)
is recommended to avoid accidential unsafe Buffer API usage.
is recommended to avoid accidental unsafe Buffer API usage.

There is also a [JSCodeshift codemod](https://github.com/joyeecheung/node-dep-codemod#dep005)
for automatically migrating Buffer constructors to `Buffer.alloc()` or `Buffer.from()`.
Expand All @@ -87,7 +87,7 @@ your users will not observe a runtime deprecation warning when running your code
Utilize [safer-buffer](https://www.npmjs.com/package/safer-buffer) as a polyfill to support older
Node.js versions.

You would take exacly the same steps as in [Variant 1](#variant-1), but with a polyfill
You would take exactly the same steps as in [Variant 1](#variant-1), but with a polyfill
`const Buffer = require('safer-buffer').Buffer` in all files where you use the new `Buffer` api.

Make sure that you do not use old `new Buffer` API — in any files where the line above is added,
Expand Down
2 changes: 1 addition & 1 deletion workspaces/arborist/lib/arborist/reify.js
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ module.exports = cls => class Reifier extends cls {
})

// [rollbackfn, [...actions]]
// after each step, if the process was terminated, execute the rollback
// afterEach step, if the process was terminated, execute the rollback
// note that each rollback *also* calls the previous one when it's
// finished, and then the first one throws the error, so we only need
// a new rollback step when we have a new thing that must be done to
Expand Down
2 changes: 1 addition & 1 deletion workspaces/arborist/lib/calc-dep-flags.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// - a non-optional node with a non-optional edge out, the edge node should not be optional
// - a non-peer node with a non-peer edge out, the edge node should not be peer
// If a node is changed, we add to the queue and continue until no more changes.
// Flags that remain after all this unsetting should be valid.
// Flags that remain afterAll this unsetting should be valid.
// Examples:
// - a node still flagged optional must only be reachable via optional edges
// - a node still flagged peer must only be reachable via peer edges
Expand Down
2 changes: 1 addition & 1 deletion workspaces/arborist/test/arborist/build-ideal-tree.js
Original file line number Diff line number Diff line change
Expand Up @@ -1563,7 +1563,7 @@ t.test('more peer dep conflicts', async t => {
'@isaacs/testing-peer-dep-conflict-chain-p': '1',
},
},
// XXX should this be false? it's not OUR fault, after all?
// XXX should this be false? it's not OUR fault, afterAll?
// but it is a conflict in a peerSet that the root is sourcing.
error: true,
},
Expand Down
Loading