Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
JReinhold
left a comment
JReinhold
left a comment
There was a problem hiding this comment.
my suggestions here could potentially be a longer-term solution to the unsupported parts of nuxt.
sacrosanctic
force-pushed
the
storybook
branch
from
f441ce8 to
e726dde
Compare
sacrosanctic
force-pushed
the
storybook
branch
from
e726dde to
eff116d
Compare
sacrosanctic
force-pushed
the
storybook
branch
from
1344552 to
4478f7e
Compare
JReinhold
left a comment
JReinhold
left a comment
There was a problem hiding this comment.
great job! I didn't look too much into the stories themselves, but it looked good.
No worries, the stories will be iterative. I will be removing them so they can be discussed in their own PR. |
sacrosanctic
force-pushed
the
storybook
branch
from
4478f7e to
4778120
Compare
Improve Storybook setup
cylewaitforit
left a comment
cylewaitforit
left a comment
There was a problem hiding this comment.
Very much looking forward to this!
| const meta = { | ||
| component: Component, | ||
| // component scope configuration goes here | ||
| } satisfies Meta<typeof Component> |
There was a problem hiding this comment.
suggestion(non-blocking): Could we use eslint-plugin-storybook's meta-satisfies-type rule to enforce this?
There was a problem hiding this comment.
can be done in a separate PR
4 participants
In this PR
todo
considerations
notes
notes to self