Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThe chart configuration in the TrendsChart component has been modified to increase the right padding from 100 to 128 pixels. This adjustment provides additional space for the final datapoint labels to render without truncation. The change affects a single line in the manifest file and does not alter any exported or public signatures. Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
app/components/Package/TrendsChart.vue (1)
1413-1413: LGTM — padding increase directly addresses locale-specific label truncation.The bump from 100 → 128 gives the injected SVG
<text>labels indrawLastDatapointLabel28 additional pixels of breathing room, which resolves the reported truncation for Cyrillic and CJK compact-number strings (e.g., "30,4 млн.").One optional consideration:
drawLastDatapointLabeluses a hardcodedfont-size="24"that does not scale withisMobile.value, whereas every other text size in the chart config doubles on mobile (isMobile.value ? 24 : 16,isMobile.value ? 32 : 24). If that font size is ever made responsive, the right padding would need revisiting. Given the current code keeps font-size fixed at 24, the static value of 128 is internally consistent.🔍 If
drawLastDatapointLabelis ever made mobile-aware, align the padding accordingly- padding: { bottom: displayedGranularity.value === 'yearly' ? 84 : 64, right: 128 }, // padding right is set to leave space of last datapoint label(s) + padding: { bottom: displayedGranularity.value === 'yearly' ? 84 : 64, right: isMobile.value ? 192 : 128 }, // padding right is set to leave space of last datapoint label(s)This would only be relevant once
font-sizeindrawLastDatapointLabelis also made responsive.
Resolves #1618
(tested with 999.9)