Skip to content

fix: skip emoji conversion inside code blocks #2694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gameroman wants to merge 2 commits into
base: main
Choose a base branch
from
+13 −12
Draft

fix: skip emoji conversion inside code blocks #2694

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ca0592
fix: skip emoji conversion inside code blocks
gameroman May 9, 2026
f11a57c
[autofix.ci] apply automated fixes
autofix-ci[bot] May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions shared/utils/emoji.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// copied from https://github.com/markdown-it/markdown-it-emoji/blob/master/lib/data/full.mjs
const emojis = {
const emojis: Record<string, string> = {
'100': '💯',
'1234': '🔢',
'grinning': '😀',
Expand Down Expand Up @@ -1905,15 +1905,16 @@ const emojis = {
'wales': '🏴󠁧󠁢󠁷󠁬󠁳󠁿',
}

const emojisKeysRegex = new RegExp(
Object.keys(emojis)
.map(key => `:${key}:`)
.join('|'),
'g',
)
export function convertToEmoji(text: string): string {
return text.replace(emojisKeysRegex, match => {
const key = match.slice(1, -1) as keyof typeof emojis
return emojis[key] || match
})
export function convertToEmoji(html: string): string {
return html.replace(
/(<code[\s>][\s\S]*?<\/code>|<pre[\s>][\s\S]*?<\/pre>)|(:[\w+-]+:)/gi,
(match, codeBlock: string | undefined, shortcode: string | undefined) => {
if (codeBlock) return codeBlock
if (shortcode) {
const key = shortcode.slice(1, -1)
return emojis[key] ?? shortcode
}
return match
},
)
}
Loading