feat: update downloads title desc and translate zh-CN/zh-TW#2695
Open
btea wants to merge 6 commits intonpmx-dev:mainfrom
Open
feat: update downloads title desc and translate zh-CN/zh-TW#2695btea wants to merge 6 commits intonpmx-dev:mainfrom
btea wants to merge 6 commits intonpmx-dev:mainfrom
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Contributor
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (15)
✅ Files skipped from review due to trivial changes (7)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR makes download counts on the package versions page version-aware for accessibility by adding a new i18n key ChangesDownloads Versioning & Localization
Possibly Related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/pages/package/`[[org]]/[name]/versions.vue:
- Around line 549-555: The header rows are passing the internal group key into
getDownloadsAriaLabel which can surface an internal identifier; update the calls
that build the header aria/title text to pass the user-facing label instead (use
item.label or an explicit display string) rather than item.groupKey—specifically
change the getDownloadsAriaLabel invocations for grouped header rows
(references: getDownloadsAriaLabel, item.groupKey, item.label,
groupDownloadsMap.get(...)) so the tooltip/aria text shows the displayed group
label while still using groupDownloadsMap.get(item.groupKey)! to fetch counts.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: cb71e376-6708-4870-adba-ceeb68208100
📒 Files selected for processing (18)
app/pages/package/[[org]]/[name]/versions.vuei18n/locales/cs-CZ.jsoni18n/locales/de.jsoni18n/locales/en.jsoni18n/locales/es.jsoni18n/locales/fr-FR.jsoni18n/locales/id-ID.jsoni18n/locales/nb-NO.jsoni18n/locales/nl.jsoni18n/locales/pt-BR.jsoni18n/locales/pt-PT.jsoni18n/locales/ru-RU.jsoni18n/locales/sr-Latn-RS.jsoni18n/locales/uk-UA.jsoni18n/locales/vi-VN.jsoni18n/locales/zh-CN.jsoni18n/locales/zh-TW.jsoni18n/schema.json
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@i18n/locales/en.json`:
- Around line 1676-1677: The brand object in the locale JSON has duplicated
"heading" keys which overwrote the intended value and breaks the schema
expecting both "title" and "heading"; locate the duplicate keys in the brand
object and rename the first "heading": "Brand" entry to "title": "Brand" so the
object contains both "title" and "heading" properties (preserving the second
"heading": "brand") to restore schema compliance.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e5bb1aae-711c-482c-9155-501c244306c2
📒 Files selected for processing (5)
app/pages/package/[[org]]/[name]/versions.vuei18n/locales/en.jsoni18n/locales/zh-CN.jsoni18n/locales/zh-TW.jsoni18n/schema.json
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
🧭 Context
We've made the download count descriptions clearer and more accurate, and updated the relevant Chinese translations.
📚 Description