Leaflet 1.x

[schendtj]

Updates for Leaflet 1.x

[nreese]

Looks like the filter by polygon is broken with leaflet 1.x. The draw:created event handler needs to be tweaked to handle leaflet 1.x constructs. See screen shot below and update how the lat and lon are pulled from the event. Right now, they are pulling undefined values.

[nreese]

Map zooming produces weird artifacts like those described in leaflet issues 4774 and 4247. Looks like this is an issue caused by the old leaflet CSS. Any ideas on how to fix?

[schendtj]

I'll take a look at it today.

…

On Tue, Dec 20, 2016 at 8:33 AM, Nathan Reese ***@***.***> wrote: Map zooming produces weird artifacts like those described in leaflet issues 4774 <Leaflet/Leaflet#4774> and 4247 <Leaflet/Leaflet#4247>. Looks like this is an issue caused by the old leaflet CSS. Any ideas on how to fix? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#24 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQ1gDQIjz8mo7m6I2F7yC-hLsRn54JqGks5rJ_VYgaJpZM4LQ9Yt> .

-- Jonathan M. Schendt Software Engineer - Integrity Applications Incorporated 19023 E Low Dr Aurora, CO 80015 608.728.0053 ACM Member # 3629480 Jon.Schendt@gmail.com

[schendtj]

Nathan, check out the css issue again, I'm not able to recreate any transition issues similar to Leaflet issues 4774 and 4247. The tilemap renders after the redraw, so there's a small delay where circles/polygons appear larger/smaller than they should, but nothing is moving to the corners.

[nreese]

your gif is showing the issue. See how the vectors jump off of their lat/lon. That should not happen and is very jolting. Switch back to leaflet 0.7 and do some zooms. It should look like that

[schendtj]

I checked Leaflet 0.7 before I made the gif. Leaflet 0.7 looks worse in terms of vector distortion. I forced the leaflet css in vis.html, and there are some minor improvements, but there's still a little distortion.

[nreese]

Zooming looks good now.

There seems to be something wrong with leaflet.draw and drawing a polygon. In the old version, double clicking closed the polygon. Now that does not work. You can not even close the shape by clicking on the last point.

[nreese]

This line should be removed since leaflet.css is no longer in node/modules

[schendtj]

I think we're seeing something similar to:

Clockwise drawing of polygon fails + cannot close polygon on Windows + Chrome #637

I'll pull the latest leaflet.draw and see if that fixes the issues on Chrome+IE