Skip to content

fix: pr_body_template が --task 実行時に無視される#538

Merged
nrslib merged 4 commits intomainfrom
takt/488/fix-pr-body-template
Apr 6, 2026
Merged

fix: pr_body_template が --task 実行時に無視される#538
nrslib merged 4 commits intomainfrom
takt/488/fix-pr-body-template

Conversation

@nrslib
Copy link
Copy Markdown
Owner

@nrslib nrslib commented Mar 21, 2026

Summary

  • buildPipelinePrBodytemplate && issue の条件だったため、issue なしの --task 実行時にテンプレートが無視されていた
  • issue が undefined でもテンプレート展開するよう修正し、各フィールドを空文字にフォールバック
  • テスト追加: task-based PR作成時のテンプレート展開を検証

Closes #488

@nrslib
Copy link
Copy Markdown
Owner Author

nrslib commented Mar 26, 2026

/resolve

@github-actions
Copy link
Copy Markdown
Contributor

🚀 cc-resolve started: View logs

@github-actions
Copy link
Copy Markdown
Contributor

✅ cc-resolve completed. View logs

@nrslib
Copy link
Copy Markdown
Owner Author

nrslib commented Mar 26, 2026

仕様として、pr_body_template 自体は issue なしの task ベース PR でも使えるようにしたいです。ただし issue がない場合は {report} のみ使用可にして、{issue} / {title} / {issue_body} を含んでいたら空文字展開ではなくエラーにしてください。

Closes #{issue} / Resolves #{issue}Closes # になるのは避けたいです。

@nrslib
Copy link
Copy Markdown
Owner Author

nrslib commented Apr 5, 2026

/resolve

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

🚀 cc-resolve started: View logs

github-actions bot and others added 2 commits April 5, 2026 00:16
Keep HEAD's new test 'should use pr_body_template for task-based PR creation
when issue is unavailable', updating expected body text from 'Piece' to
'Workflow' to match main branch terminology change.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

✅ cc-resolve completed. View logs

@nrslib nrslib merged commit 415d662 into main Apr 6, 2026
3 checks passed
@nrslib nrslib deleted the takt/488/fix-pr-body-template branch April 6, 2026 14:22
@nrslib nrslib mentioned this pull request Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pr_body_template が --task 実行時に無視される

1 participant