Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
概要
現在、すべてのムーブメントに対して git add / git commit / git push の禁止がテンプレート
.mdにハードコードされている。大量の issue を1つのタスクで消化するワークフローなど、作業単位ごとに git commit したいユースケースに対応するため、ムーブメント単位でこの制約をオプトインで解除できるようにする。変更内容
PieceMovementにallow_git_commit: boolean(デフォルトfalse)を追加allow_git_commit: trueの場合、git add / git commit / git push 禁止セクションを注入しない.mdからハードコード除去し、buildGitCommitRule()で条件付き注入する方式に変更(buildEditRule()と同様のパターン)変更ファイル
src/core/models/workflow-schemas.tsPieceMovementRawSchema/ParallelSubMovementRawSchemaにallow_git_commit追加src/core/models/piece-types.tsPieceMovementにallowGitCommit: boolean追加src/infra/config/loaders/pieceParser.tsallow_git_commit→allowGitCommitマッピング追加src/core/piece/instruction/instruction-context.tsbuildGitCommitRule()関数を追加src/core/piece/instruction/InstructionBuilder.tsgitCommitRule変数を注入src/core/piece/instruction/ReportInstructionBuilder.tsgitCommitRule変数を注入src/shared/prompts/{en,ja}/perform_phase1_message.md{{#if gitCommitRule}}条件ブロックsrc/shared/prompts/{en,ja}/perform_phase2_message.mdsrc/core/piece/engine/PieceEngine.tsallowGitCommit: false追加src/core/piece/engine/team-leader-common.tsallowGitCommitを引継ぎsrc/__tests__/instruction-context.test.tsbuildGitCommitRuleユニットテスト 9 件追加src/__tests__/instructionBuilder.test.tssrc/__tests__/instruction-template-removal.test.tssrc/__tests__/prompts.test.tsピースYAMLでの使用例
Execution Report
Workflow
takt-defaultcompleted successfully.Closes #587