Open
Conversation
…d it send the messages every second to prevent kick for too many messsages sent. (Issue nullsoepic#10)
Contributor
Author
|
I havent tested it yet cause i don't have a bot set up but it should work |
112batman
suggested changes
Dec 7, 2022
112batman
left a comment
112batman
left a comment
There was a problem hiding this comment.
Use setInterval(lambda) instead as it's non-blocking
| messageQueue.push(message.content); | ||
| } | ||
|
|
||
| while (messageQueue.length > 0) { |
There was a problem hiding this comment.
A while true loop hangs the program I think
| while (messageQueue.length > 0) { | ||
| if (!sending) { | ||
| bot.write('chat_message', { | ||
| message: message.author.tag + ' > ' + messageQueue[0], |
There was a problem hiding this comment.
Replace this with messageQueue.shift()
| lastMessage: null | ||
| }); // Send the message to minecraft chat | ||
|
|
||
| messageQueue.shift(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added kick protection. If someone sends a long message it splits it and it send the messages every second to prevent kick for too many messsages sent. (Issue #10 )