Skip to content

Add submodule for translations #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nvdaes wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Add submodule for translations #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f1c7013
Add submodule for translations
nvdaes Dec 20, 2025
0243feb
Update dependencies
nvdaes Dec 20, 2025
22346c0
Update dependencies
nvdaes Dec 20, 2025
1140813
Exclude _l10n from Pyright since errors are reported regarding deprec…
nvdaes Dec 20, 2025
ca76d71
Update files from master
nvdaes Jan 22, 2026
42301e1
Remove file
nvdaes Jan 22, 2026
af5a5e8
Update pyproject
nvdaes Jan 22, 2026
92a9c09
Update lock file
nvdaes Jan 22, 2026
74cca59
Remove _l10n
nvdaes Jan 24, 2026
e63084a
Remove gitmodules
nvdaes Jan 24, 2026
0329be1
Add nvaccess/nvdaL10n submodule
nvdaes Jan 24, 2026
6c422a2
Added workflow to check the submodule and run executable
nvdaes Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .github/workflows/l10n.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: NVDA l10n

on:
push:
branches:
- main

pull_request:

branches:
- main

workflow_dispatch:

jobs:
nvdaL10n:

runs-on: ubuntu-latest

steps:
- name: Checkout repository
uses: actions/checkout@v6
with:
submodules: true
- name: Create executable
run: |
pyInstaller --onefile _l10n/source/l10nUtil.py
Copy link
Copy Markdown
Member

@seanbudd seanbudd Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead can we build the exe in nvdal10n and just add the exe to file here?

Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The executable name is typically pyinstaller (lowercase) on Linux. Using pyInstaller may fail on case-sensitive shells. Adjust the command to the installed executable name to avoid a CI failure.

Suggested change
pyInstaller --onefile _l10n/source/l10nUtil.py
pyinstaller --onefile _l10n/source/l10nUtil.py

Copilot uses AI. Check for mistakes.
Comment on lines +25 to +27
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After checkout, the workflow goes straight to building an executable without setting up Python or installing runtime deps (e.g., PyInstaller). Add actions/setup-python and an install step (pip/uv) before the build step so the job is reproducible on ubuntu-latest.

Suggested change
- name: Create executable
run: |
pyInstaller --onefile _l10n/source/l10nUtil.py
- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: '3.x'
- name: Install build dependencies
run: |
python -m pip install --upgrade pip
python -m pip install pyinstaller
- name: Create executable
run: |
python -m PyInstaller --onefile _l10n/source/l10nUtil.py

Copilot uses AI. Check for mistakes.
3 changes: 3 additions & 0 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[submodule "_l10n"]
path = _l10n
url = https://github.com/nvaccess/nvdaL10n
1 change: 1 addition & 0 deletions _l10n
Open in desktop
Submodule _l10n added at d946cf
55 changes: 53 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,46 @@
[build-system]
requires = ["setuptools~=80.9", "wheel"]
build-backend = "setuptools.build_meta"

[project]
name = "addonTemplate"
dynamic = ["version"]
description = "NVDA add-on template"
maintainers = [
{name = "NV Access", email = "info@nvaccess.org"},
]
requires-python = ">=3.13,<3.14"
classifiers = [
"Development Status :: 5 - Production/Stable",
"Intended Audience :: End Users/Desktop",
"License :: OSI Approved :: GNU General Public License v2 or later (GPLv2+)",
"Operating System :: Microsoft :: Windows",
"Programming Language :: Python :: 3",
"Topic :: Accessibility",
]
readme = "readme.md"
license = {file = "COPYING.TXT"}
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license = {file = "COPYING.TXT"} references a filename that doesn't exist in the repo (the file is COPYING.txt). On case-sensitive filesystems (e.g., Linux CI/builds), this will break packaging/build metadata resolution. Update the filename to match the actual casing, or rename the file consistently.

Suggested change
license = {file = "COPYING.TXT"}
license = {file = "COPYING.txt"}

Copilot uses AI. Check for mistakes.
dependencies = [
# Build add-on
"scons==4.10.1",
"Markdown==3.10",
# Translations management
"requests==2.32.5",
"nh3==0.3.2",
"crowdin-api-client==1.24.1",
"lxml==6.0.2",
"mdx_truly_sane_lists==1.3",
"markdown-link-attr-modifier==0.2.1",
"mdx-gh-links==0.4",
# Lint
"uv==0.9.11",
"ruff==0.14.5",
"pre-commit==4.2.0",
"pyright[nodejs]==1.1.407",
]
[project.urls]
Repository = "https://github.com/nvaccess/addonTemplate"

[tool.ruff]
line-length = 110

Expand All @@ -20,10 +63,13 @@ include = [
exclude = [
".git",
"__pycache__",
".venv",
"buildVars.py",
]

[tool.ruff.format]
indent-style = "tab"
line-ending = "lf"

[tool.ruff.lint.mccabe]
max-complexity = 15
Expand All @@ -33,13 +79,16 @@ ignore = [
# indentation contains tabs
"W191",
]
logger-objects = ["logHandler.log"]

[tool.ruff.lint.per-file-ignores]
# sconstruct contains many inbuilt functions not recognised by the lint,
# sconscripts contains many inbuilt functions not recognised by the lint,
# so ignore F821.
"sconstruct" = ["F821"]

[tool.pyright]
venvPath = ".venv"
venv = "."
pythonPlatform = "Windows"
typeCheckingMode = "strict"

Expand All @@ -51,6 +100,8 @@ exclude = [
"sconstruct",
".git",
"__pycache__",
".venv",
"site_scons",
# When excluding concrete paths relative to a directory,
# not matching multiple folders by name e.g. `__pycache__`,
# paths are relative to the configuration file.
Expand All @@ -59,6 +110,7 @@ exclude = [
# Tell pyright where to load python code from
extraPaths = [
"./addon",
"../nvda/source",
]

# General config
Expand Down Expand Up @@ -120,7 +172,6 @@ reportPropertyTypeMismatch = true
reportRedeclaration = true
reportReturnType = true
reportSelfClsParameterName = true
reportShadowedImports = true
reportTypeCommentUsage = true
reportTypedDictNotRequiredAccess = true
reportUnboundVariable = true
Expand Down
Loading
Loading