Skip to content

Update build-discussion action to v2#8293

Merged
seanbudd merged 1 commit intonvaccess:masterfrom
nvdaes:updateBuildDiscussionAction
Apr 7, 2026
Merged

Update build-discussion action to v2#8293
seanbudd merged 1 commit intonvaccess:masterfrom
nvdaes:updateBuildDiscussionAction

Conversation

@nvdaes
Copy link
Copy Markdown
Contributor

@nvdaes nvdaes commented Apr 2, 2026

Summary of the issue

I've updated nvdaes/build-discussion action to v2, transforming the JavaScript action to composite using a bash script, to be able to maintain it without dealing with dependencies. I'm using GH CLI, as recently done in nvdal10nUtil for releases.

Development approach

Bump version.

Testing performed

I've setup pre-commit with linters for Bash script and markdown, as well as the ci (integration previous check), which creates a discussion on push to main and on pull request.

Repo: https://github.com/nvdaes/build-discussion

Copilot AI review requested due to automatic review settings April 2, 2026 16:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Actions workflow that creates GitHub Discussions for add-on reviews by bumping the nvdaes/build-discussion action from v1 to v2.

Changes:

  • Update nvdaes/build-discussion action reference from @v1 to @v2 in the add-on metadata workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nvdaes
Copy link
Copy Markdown
Contributor Author

nvdaes commented Apr 7, 2026

@seanbudd wrote:

is it worth replacing this with...

Not sure, but probably the code should be more complex, and capture discussion URL.
If you want, I can create an actions folder to store my action on this repo for your review and more control.
Let me know.

@seanbudd seanbudd merged commit d491967 into nvaccess:master Apr 7, 2026
6 of 7 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 7, 2026
Commit message:
Update build-discussion action to v2 (#8293)
Summary of the issue

I've updated nvdaes/build-discussion action to v2, transforming the JavaScript action to composite using a bash script, to be able to maintain it without dealing with dependencies. I'm using GH CLI, as recently done in nvdal10nUtil for releases.
Development approach

Bump version.
Testing performed

I've setup pre-commit with linters for Bash script and markdown, as well as the ci (integration previous check), which creates a discussion on push to main and on pull request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants