Skip to content

Conversation

@comfysage
Copy link
Contributor

@comfysage comfysage commented Jan 6, 2026

thnx for the awesome plugins. noticed this while reading through the source code.

@echasnovski
Copy link
Member

Thanks for the PR!

This looks reasonable. It needs a test, though. Would you like to update an existing one or are you okay with me doing it?

@comfysage
Copy link
Contributor Author

ill work on the test :)

(i should write tests for my plugins)

@echasnovski
Copy link
Member

Could you please remove unrelated new file?
By the way, It should always be cleaned. You probably stopped running 'mini.visits' tests in the middle, right? To right only a single test file, you can either make test_basics in the command line or :lua MiniTest.run_file() when the test file is current.

@comfysage
Copy link
Contributor Author

To right only a single test file, you can either make test_basics in the command line or :lua MiniTest.run_file() when the test file is current.

yeah i figured that out later. i hadnt realized it created a temp file. sorry for that

@comfysage comfysage force-pushed the fix/basics/selectchanged/keepjumps branch from b256056 to be316b6 Compare January 7, 2026 12:54
@echasnovski echasnovski changed the base branch from main to backlog January 8, 2026 14:33
@echasnovski echasnovski merged commit 0da19b2 into nvim-mini:backlog Jan 8, 2026
10 of 12 checks passed
@comfysage comfysage deleted the fix/basics/selectchanged/keepjumps branch January 8, 2026 15:35
@echasnovski
Copy link
Member

This should now be part of the main branch (after rebase and squash). Thanks again for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants