feat(capture): Support for %^g and %^G expansions in capture templates.#1132
Open
alecStewart1 wants to merge 6 commits into
Open
feat(capture): Support for %^g and %^G expansions in capture templates.#1132alecStewart1 wants to merge 6 commits into
%^g and %^G expansions in capture templates.#1132alecStewart1 wants to merge 6 commits into
Conversation
alecStewart1
changed the title
%^g and %^G expansions in capture templates.%^g and %^G expansions in capture templates.
alecStewart1
force-pushed
the
capture-g-expansions
branch
from
fb38130 to
ac275b0
Compare
kristijanhusak
requested changes
May 2, 2026
alecStewart1
force-pushed
the
capture-g-expansions
branch
from
bfdd2cd to
7fab341
Compare
kristijanhusak
requested changes
May 3, 2026
Member
kristijanhusak
left a comment
kristijanhusak
left a comment
There was a problem hiding this comment.
Thanks for the changes! It is much better, but there are still few things to address before merging.
| local prepared_inputs = {} | ||
| for exp in content:gmatch('%%%^%b{}') do | ||
| -- Match %^{...} with optional g/G suffix for tag prompts | ||
| for exp in content:gmatch('%%%^%b{}[gG]?') do |
Member
There was a problem hiding this comment.
Why do we need this change?
Contributor
Author
There was a problem hiding this comment.
I'll double check, but I was running into some issue with g/G still being with the resulting tag(s).
Contributor
Author
There was a problem hiding this comment.
To clarify: without this, tests were failing and the outputted tags when I tested would include g/G.
Contributor
Author
|
The CI failures on macos/ubuntu are 4 refile tests in |
added 5 commits
May 4, 2026 11:09
…t. Maybe need to remove comments.
… existing autocomplete functionality, and match what Emacs does better.
alecStewart1
force-pushed
the
capture-g-expansions
branch
from
629b123 to
d7eac0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add capture expansions for:
%^g:%^G:Changes
Added functions:
uniq_tagsget_target_tags(for%^g)get_all_tags(for%^G)For getting tags for
%^g/%^Gexpansions.Added
prompt_tagsto prompt on%^g/%^Gexpansions.The above are used in
expansionsinlua/orgmode/capture/template/init.lua.Addressed LuaLS warning in
lua/orgmode/capture/templates.luaregardingtemplates or config.org_capture_templates.Added plenary tests, update test helper
create_agenda_filesto return files for template tests.Checklist
I confirm that I have:
Conventional Commits
specification (e.g.,
feat: add new feature,fix: correct bug,docs: update documentation).make test.