fix(links): creating link from visual mode#1139
Merged
Merged
Conversation
Contributor
Author
|
Did some digging and it seems like the failing test runs on nightly are due to neovim/neovim@7ed5609 |
Selecting a region from right to left could lead to insert_from > insert_to, which isn't handled in later code. By using getregionpos the regions will be in the correct order.
kristijanhusak
force-pushed
the
lanker/link.create
branch
from
5b56194 to
50762a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Selecting a region from right to left could lead to insert_from > insert_to, which isn't handled in later code. By using getregionpos the regions will be in the correct order.
Related Issues
Closes #900
Changes
Checklist
I confirm that I have:
Conventional Commits
specification (e.g.,
feat: add new feature,fix: correct bug,docs: update documentation).make test.