[codex] fix warnings across targets

cookie.mbt

@@ -69,7 +69,7 @@ pub fn parse_cookie(cookie : StringView) -> Map[String, CookieItem] {
         "(?i:max-age)" =>
           {
             ..item,
-            max_age: try @strconv.parse_int(value) catch {
+            max_age: try @string.parse_int(value) catch {
               _ => None
             } noraise {
               x => Some(x)

examples/responder/pkg.generated.mbti

@@ -10,9 +10,7 @@ import {
 // Errors
 
 // Types and methods
-type Person
-pub impl ToJson for Person
-pub impl @json.FromJson for Person
+type Person derive(ToJson, @json.FromJson)
 
 // Type aliases
 

fetch.js.mbt

@@ -54,7 +54,7 @@ pub async fn fetch(
   if req_body is Some(body_str) {
     options["body"] = body_str
   }
-  if not(req_headers.is_empty()) {
+  if !req_headers.is_empty() {
     let headers_obj = @js.Object::new()
     req_headers.each(fn(k, v) { headers_obj[k] = v })
     options["headers"] = headers_obj.to_value()

fetch.wasm.mbt

@@ -9,11 +9,14 @@ pub async fn fetch(
   mode? : FetchMode,
 ) -> HttpResponse raise Error {
   ignore(url)
-  ignore(body)
   ignore(http_method)
-  ignore(data)
-  ignore(headers)
   ignore(credentials)
   ignore(mode)
-  raise FetchError::RequestFailed("fetch is not implemented on wasm target")
+  ignore(body)
+  ignore(data)
+  ignore(headers)
+  ignore(prepare_fetch_payload)
+  suspend(fn(_ok_cb, reject) {
+    reject(FetchError::RequestFailed("fetch is not implemented on wasm target"))
+  })
 }

js/async_test.mbt

@@ -16,7 +16,7 @@ fn op3() -> String? noraise {
 
 ///|
 test "Promise::wait" {
-  @js.async_test(fn() raise {
+  @js.async_test(async fn() {
     // Promise::unsafe_new + Promise::wait is a noop.
     let res = @js.Promise::unsafe_new(() => op1()).wait()
     assert_eq(res.cast(), Some("Hello"))
@@ -25,7 +25,7 @@ test "Promise::wait" {
 
 ///|
 test "async_all" {
-  @js.async_test(fn() raise {
+  @js.async_test(async fn() {
     assert_eq(@js.async_all([() => op2(), () => op1(), () => op3()]), [
       Some("Hello, World"),
       Some("Hello"),

js/cast.mbt

@@ -85,7 +85,7 @@ pub impl[A : Cast] Cast for Array[A] with into(value) {
   checked_cast_array_ffi(value)
   .to_option()
   .bind(fn(arr) {
-    let is_type_a = fn(elem) { not((Cast::into(elem) : A?) is None) }
+    let is_type_a = fn(elem) { !((Cast::into(elem) : A?) is None) }
     if arr.iter().all(is_type_a) {
       Some(Value::cast_from(arr).cast())
     } else {

js/error.mbt

@@ -10,7 +10,7 @@ extern "js" fn Error_::cause_ffi(self : Value) -> Value = "(self) => self.cause"
 pub fn Error_::cause(self : Error_) -> Value? {
   let Error_(inner) = self
   let cause = Error_::cause_ffi(inner)
-  guard not(cause.is_undefined()) else { None }
+  guard !cause.is_undefined() else { None }
   Some(cause.cast())
 }
 

js/null.mbt

@@ -21,7 +21,7 @@ pub fn[T] Nullable::unwrap(self : Nullable[T]) -> T {
 
 ///|
 pub fn[T] Nullable::to_option(self : Nullable[T]) -> T? {
-  guard not(Value::cast_from(self).is_null()) else { None }
+  guard !Value::cast_from(self).is_null() else { None }
   Some(self.get_exn())
 }
 

js/value_test.mbt

@@ -60,12 +60,14 @@ let json_str_pretty =
   #|}
 
 ///|
-let json_val : @js.Value = (try? @js.Value::from_json_string(json_str_pretty)).unwrap()
+fn json_val() -> @js.Value {
+  try! @js.Value::from_json_string(json_str_pretty)
+}
 
 ///|
 test "Value::to_json_string" {
   inspect(
-    json_val.to_json_string(),
+    json_val().to_json_string(),
     content=(
       #|{"_id":"67a6c712bc218526d5e1b516","index":0,"guid":"74e69a18-680a-4a74-a401-e386c30d0a35","isActive":false,"balance":"$3,140.03","picture":"http://placehold.it/32x32","age":33,"eyeColor":"blue","name":"Burt Dominguez","gender":"male","company":"GEEKWAGON","email":"burtdominguez@geekwagon.com","phone":"+1 (913) 583-3488","address":"379 Essex Street, Fresno, Minnesota, 5304","about":"Proident velit ullamco cillum occaecat irure eu proident commodo consectetur est ut elit consectetur.","registered":"2020-12-06T01:54:20 -08:00","latitude":71.680916,"longitude":-88.552886,"tags":["aute","occaecat","qui","esse","commodo","sint","proident"],"friends":[{"id":0,"name":"Gilliam Mcgowan"},{"id":1,"name":"Bryan Stanton"},{"id":2,"name":"Jenifer Elliott"}],"greeting":"Hello, Burt Dominguez! You have 4 unread messages.","favoriteFruit":"apple"}
     ),
@@ -74,13 +76,13 @@ test "Value::to_json_string" {
 
 ///|
 test "Value::to_json" {
-  assert_eq(json_val.to_json(), json)
+  assert_eq(json_val().to_json(), json)
 }
 
 ///|
 test "Value::from_json" {
   assert_eq(
     @js.Value::from_json(json).to_json_string(),
-    json_val.to_json_string(),
+    json_val().to_json_string(),
   )
 }

mocket.js.mbt

@@ -308,7 +308,7 @@ pub fn serve_ffi(mocket : Mocket, port~ : Int) -> Unit {
           let headers_obj = (try? @js.Value::from_json(
             event.res.headers.to_json(),
           )).or(@js.Object::new().to_value())
-          if not(event.res.cookies.is_empty()) {
+          if !event.res.cookies.is_empty() {
             let cookies = event.res.cookies
               .values()
               .map(fn(c) { c.to_string() })
@@ -358,7 +358,7 @@ extern "js" fn _init_bindings_map() -> @js.Value = "() => { if (!globalThis.ws_p
 pub fn register_ws_handler(mocket : Mocket, port : Int) -> Unit {
   let mut done = false
   mocket.ws_static_routes.each(fn(_, handler) {
-    if not(done) {
+    if !done {
       ws_handler_map.set(port, handler)
       ws_mocket_map.set(port, mocket)
       ignore(_init_bindings_map())

mocket.native.mbt

@@ -104,7 +104,7 @@ let ws_handler_map : Map[Int, WebSocketHandler] = Map::new()
 pub fn register_ws_handler(mocket : Mocket, port : Int) -> Unit {
   let mut done = false
   mocket.ws_static_routes.each(fn(_, handler) {
-    if not(done) {
+    if !done {
       ws_handler_map.set(port, handler)
       done = true
     }

mocket.wasm.mbt

@@ -1,5 +1,67 @@
+///|
+fn wasm_websocket_peer() -> WebSocketPeer {
+  WebSocketPeer::{ connection_id: "", subscribed_channels: [] }
+}
+
+///|
+fn keep_websocket_symbols_alive() -> Unit {
+  ignore(WebSocketEvent::Open(wasm_websocket_peer()))
+  ignore(
+    WebSocketEvent::Message(
+      wasm_websocket_peer(),
+      WebSocketAggregatedMessage::Text(""),
+    ),
+  )
+  ignore(WebSocketEvent::Close(wasm_websocket_peer()))
+  ignore(WebSocketAggregatedMessage::Binary(b""))
+  ignore(WebSocketAggregatedMessage::Ping)
+}
+
 ///|
 pub fn serve_ffi(mocket : Mocket, port~ : Int) -> Unit {
-  // Unimplemented
+  ignore(mocket.find_route("GET", "/"))
+  ignore(port)
+  keep_websocket_symbols_alive()
+  panic()
+}
+
+///|
+pub fn ws_send(id : String, msg : String) -> Unit {
+  ignore(id)
+  ignore(msg)
+  panic()
+}
+
+///|
+pub fn ws_send_bytes(id : String, msg : Bytes) -> Unit {
+  ignore(id)
+  ignore(msg)
+  panic()
+}
+
+///|
+pub fn ws_pong(id : String) -> Unit {
+  ignore(id)
+  panic()
+}
+
+///|
+pub fn ws_subscribe(id : String, channel : String) -> Unit {
+  ignore(id)
+  ignore(channel)
+  panic()
+}
+
+///|
+pub fn ws_unsubscribe(id : String, channel : String) -> Unit {
+  ignore(id)
+  ignore(channel)
+  panic()
+}
+
+///|
+pub fn ws_publish(channel : String, msg : String) -> Unit {
+  ignore(channel)
+  ignore(msg)
   panic()
 }

moon.pkg

@@ -7,6 +7,7 @@ import {
   "moonbitlang/x/codec/base64",
   "moonbitlang/core/json",
   "moonbitlang/core/strconv",
+  "moonbitlang/core/string",
   "moonbitlang/core/buffer",
   "moonbitlang/core/encoding/utf8",
 }

path_match.mbt

@@ -2,7 +2,7 @@
 // 匹配路径并提取参数 - 重写版本，消除复杂性
 fn match_path(template : String, path : String) -> Map[String, StringView]? {
   // 静态路径直接比较 - 好品味：消除特殊情况
-  if not(template.contains(":")) && not(template.contains("*")) {
+  if !template.contains(":") && !template.contains("*") {
     return if template == path { Some({}) } else { None }
   }
 

pkg.generated.mbti

@@ -56,19 +56,15 @@ pub fn ws_subscribe(String, String) -> Unit
 pub fn ws_unsubscribe(String, String) -> Unit
 
 // Errors
-pub suberror ExecError
-pub impl Show for ExecError
+pub suberror ExecError derive(Show)
 
 pub suberror FetchError {
   RequestFailed(String)
-}
-pub impl Show for FetchError
+} derive(Show)
 
-pub suberror IOError
-pub impl Show for IOError
+pub suberror IOError derive(Show)
 
-pub suberror NetworkError
-pub impl Show for NetworkError
+pub suberror NetworkError derive(Show)
 
 // Types and methods
 pub(all) struct CookieItem {
@@ -80,28 +76,23 @@ pub(all) struct CookieItem {
   secure : Bool?
   http_only : Bool?
   same_site : SameSiteOption?
-}
-pub impl Eq for CookieItem
+} derive(Eq)
 pub impl Show for CookieItem
 
 pub(all) enum FetchCredentials {
   Omit
   SameOrigin
   Include
-}
+} derive(Eq, Show)
 pub fn FetchCredentials::to_string(Self) -> String
-pub impl Eq for FetchCredentials
-pub impl Show for FetchCredentials
 
 pub(all) enum FetchMode {
   Cors
   NoCors
   SameOrigin
   Navigate
-}
+} derive(Eq, Show)
 pub fn FetchMode::to_string(Self) -> String
-pub impl Eq for FetchMode
-pub impl Show for FetchMode
 
 type Html
 pub impl Responder for Html
@@ -116,9 +107,7 @@ pub(all) enum HttpMethod {
   OPTIONS
   TRACE
   CONNECT
-}
-pub impl Eq for HttpMethod
-pub impl Show for HttpMethod
+} derive(Eq, Show)
 
 pub(all) struct HttpRequest {
   http_method : String
@@ -202,9 +191,7 @@ pub(all) enum SameSiteOption {
   Lax
   Strict
   SameSiteNone
-}
-pub impl Eq for SameSiteOption
-pub impl Show for SameSiteOption
+} derive(Eq, Show)
 pub impl ToJson for SameSiteOption
 
 pub(all) struct StaticAssetMeta {
@@ -281,12 +268,9 @@ pub(all) enum StatusCode {
   NotExtended
   NetworkAuthenticationRequired
   Custom(Int)
-}
+} derive(Eq, Show, ToJson)
 pub fn StatusCode::from_int(Int) -> Self
 pub fn StatusCode::to_int(Self) -> Int
-pub impl Eq for StatusCode
-pub impl Show for StatusCode
-pub impl ToJson for StatusCode
 
 pub enum WebSocketAggregatedMessage {
   Text(String)

static.mbt

@@ -43,7 +43,7 @@ pub fn Mocket::static_assets(
   provider : &ServeStaticProvider,
 ) -> Unit {
   self.use_middleware(async fn(event, next) noraise {
-    if not(match_path(path, event.req.url) is None) {
+    if !(match_path(path, event.req.url) is None) {
       return next()
     }
 
@@ -126,7 +126,7 @@ pub fn Mocket::static_assets(
         }
         match meta.etag {
           Some(etag) => {
-            if not(event.res.headers.contains("ETag")) {
+            if !event.res.headers.contains("ETag") {
               event.res.headers.set("ETag", etag)
             }
             if event.req.headers.get("If-None-Match") == Some(etag) {
@@ -137,7 +137,7 @@ pub fn Mocket::static_assets(
         }
 
         // Content-Type
-        if not(event.res.headers.contains("Content-Type")) {
+        if !event.res.headers.contains("Content-Type") {
           match meta.asset_type {
             Some(t) => event.res.headers.set("Content-Type", t)
             None => {
@@ -156,7 +156,7 @@ pub fn Mocket::static_assets(
         // Content-Encoding
         match meta.encoding {
           Some(enc) =>
-            if not(event.res.headers.contains("Content-Encoding")) {
+            if !event.res.headers.contains("Content-Encoding") {
               event.res.headers.set("Content-Encoding", enc)
             }
           None => ()
@@ -165,7 +165,7 @@ pub fn Mocket::static_assets(
         // Content-Length
         match meta.size {
           Some(size) =>
-            if size > 0L && not(event.res.headers.contains("Content-Length")) {
+            if size > 0L && !event.res.headers.contains("Content-Length") {
               event.res.headers.set("Content-Length", size.to_string())
             }
           None => ()