-
Notifications
You must be signed in to change notification settings - Fork 34
Fixes #3640 Update eyelid textual definition #3641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Fixes #3640 to correctly classify eyelid as a facial skin
|
#gogoeditdiff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR attempts to fix issue #3640 by reclassifying the eyelid from "organ part" to "zone of skin". However, this change is semantically incorrect based on the anatomical composition of the eyelid and established ontology patterns.
Key Changes:
- Changed the parent classification of eyelid (UBERON:0001711) from "organ part" (UBERON:0000064) to "zone of skin" (UBERON:0000014)
src/ontology/uberon-edit.obo
Outdated
| xref: VHOG:0000016 | ||
| xref: Wikipedia:Eyelid | ||
| is_a: UBERON:0000064 ! organ part | ||
| is_a: UBERON:0000014 ! zone of skin |
Copilot
AI
Dec 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reclassification of eyelid as "zone of skin" is semantically incorrect. The eyelid is a complex multi-tissue structure, not just skin.
Evidence from the ontology itself:
- Line 28989 documents that eyelid consists of 7 distinct layers: skin, subcutaneous connective tissue, striated muscle, submuscular connective tissue, fibrous layer, smooth muscle, and palpebral conjunctiva
- Line 28986 notes that "FMA divides this into skin, fascia, conjunctiva"
- The ontology already has a separate term "skin of eyelid" (UBERON:0001457) that is correctly classified as a "zone of skin"
- Parts of the eyelid include levator palpebrae superioris (muscle, line 25855) and palpebral conjunctiva (mucous membrane, line 32063)
The correct pattern is established by "prepuce" (UBERON:0011374), which is also a "fold of skin and mucous membrane":
- Prepuce is classified as "external soft tissue zone", not "zone of skin"
- It has "has_part" relationships to both skin and mucosa
- Line 146065 includes a curator note: "this structure is a combination of skin and other tissue"
The eyelid should remain classified as "organ part" (UBERON:0000064) or be reclassified to something like "external soft tissue zone", with a "has_part" relationship to skin, rather than being classified directly as "zone of skin".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Fixes #3640
The eyelid is a composite anatomical structure that is not solely composed by skin. This PR updates the definition to reflect this and provides a dbxref: