Add fallback for getting device path.#31
Open
dcnieho wants to merge 1 commit intoobsproject:masterfrom
Open
Conversation
Member
|
Are there specific devices where you ran into issues that we could verify with? |
Author
|
I have observed this with two devices, both https://obsproject.com/forum/resources/obs-virtualcam.949/, and the directshow adapter for Basler machine vision cameras (part of their Pylon runtime)--the latter you can't test without having a Basler camera i think. These are both software devices i guess. |
Author
|
Ping on this one. Its also how ffmpeg's dshow gets their device paths |
Author
|
And sorry to canabalize this PR, but i can't post issues to this repo. Is it being considered to re-apply 8f2ef91? I would love to have this functionality. Anything i can do to help? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For various software devices i have, the devicePath remains empty upon
DShow::Device::EnumVideoDevices(). I have implemented a fallback method for getting the devicepath.Motivation and Context
I'd like to have device paths for as many devices, software or hardware, as possible.
How Has This Been Tested?
I have run enumDevices, called from my own application, and devicePaths for software devices are now created.
DShow::Device.SetVideoConfig() also works fine for a software device with this now non-empty path.
Types of changes
Unclear to me, seems to be a new feature.
Checklist: