libobs: Fix global transition source signals#11091
Open
Penwy wants to merge 1 commit intoobsproject:masterfrom
Open
libobs: Fix global transition source signals#11091Penwy wants to merge 1 commit intoobsproject:masterfrom
Penwy wants to merge 1 commit intoobsproject:masterfrom
Conversation
norihiro
reviewed
Aug 10, 2024
Penwy
force-pushed
the
fix_transition_signals
branch
from
c50b66f to
61fa1af
Compare
Penwy
force-pushed
the
fix_transition_signals
branch
from
61fa1af to
f45f689
Compare
Penwy
force-pushed
the
fix_transition_signals
branch
from
f45f689 to
95882ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This ensures the global transition source signals,
source_transition_start,source_transition_stopandsource_transition_video_stopactually get fired properly on the global signal handler.Motivation and Context
Due to the use of
obs_source_dosignaland to all transitions being created as private sources, those global signals were not fired, despite being implemented, and documented. This felt like an oversight.How Has This Been Tested?
Ubuntu 22.04, verified all signals got properly fired.
Types of changes
Checklist: