frontend: Make sure all scene item properties are copied

[cg2121]

Description

Scale filtering, show/hide transitions and private settings (item color) were not copied when copying scene items.

Motivation and Context

Idea from @Warchamp7

How Has This Been Tested?

Copied sources and made sure all properties were copied

Types of changes

• Tweak (non-breaking change to improve existing functionality)

Checklist:

• My code has been run through clang-format.
• I have read the contributing document.
• My code is not on the master branch.
• The code has been tested.
• All commit messages are properly formatted and commits squashed where appropriate.
• I have included updates to all appropriate documentation.

[exeldro]

This changes the copy paste behavior. Before this change you could copy a scene item, move it to a new position and paste on the original position. With this change all changes done on the scene item after the copy are also in the paste.

This pull request has a merge conflict with #8286, depending on which gets merged first the other pull request needs updating.

Instead of item and new_item I would call it source and destination in obs_sceneitem_duplicate

[cg2121]

Updated to use the original way the scene items were copied, like @exeldro suggested.

[Warchamp7]

Tested and confirmed that scale filtering and show/hide transitions are properly copied now.

The logic for show/hide transitions will need to be adjusted though. Copying the transition UUIDs means if those transitions change between copying and pasting, the data gets lost.

Ex.

• Set Show/Hide transitions on a source to Fade
• Copy the scene item
• Change the Show/Hide transitions on the source to another type
• Paste the scene item

The pasted scene item will not have any Show/Hide transitions because the copied UUIDs will be gone now.

[cg2121]

Updated to fix issue @Warchamp7 brought up and also made sure private settings (item color) were copied.