Closed
Conversation
This moves the dock toolbars to the title bar of the dock, saving space.
Collaborator
|
Just want to specify that this change can not be kept if obsproject/rfcs#47 (switch to ADS) is approved because ADS title bars can not be modified like this. Edit: Docks title bar are meant for dock tabs. |
5 tasks
Member
|
I personally disagree with this UX - it feels noisier and more confusing. I'm especially against hiding the undock/close buttons into a context menu. |
PatTheMav
reviewed
Apr 23, 2022
|
|
||
| void OBSDock::EnableControlMenu(bool lock) | ||
| { | ||
| menuButton->setVisible(!lock); |
Member
There was a problem hiding this comment.
This segfaults immediately on macOS. menuButton is NULL.
Member
|
FWIW here's how it looks on macOS:
|
GeorgesStavracas
added
the
UI/UX
Member
|
Yeah I get the intent here but I'm going to veto this one, sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This moves the dock toolbars to the title bar of
the dock, saving space.
Motivation and Context
Makes UI look better.
How Has This Been Tested?
Made sure the title bars rendered properly for each dock and made the buttons worked. Only tested on Windows 10, but should be fine elsewhere.
Types of changes
Checklist: