Capture right dune in subshell#14529
Merged
Leonidas-from-XIV merged 1 commit intoMay 15, 2026
Merged
Conversation
The tests inject the right dune, but if the test launches a shell script that gets `dune` from the path it might get the wrong one. My original hypothesis in ocaml#14528 was wrong, the outer `dune` is correct and it depends on the right dune, but the inner `dune` pointed to one in my `PATH` and not to the in-development one. Closes ocaml#14528 Signed-off-by: Marek Kubica <marek@tarides.com>
Collaborator
|
Note that this problems should go away with #14373. |
Collaborator
Author
|
Is #14373 injecting the |
rgrinberg
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests inject the right dune, but if the test launches a shell script that gets
dunefrom the path it might get the wrong one.My original hypothesis in #14528 was wrong, the outer
duneis correct and it depends on the right dune, but the innerdunepointed to one in myPATHand not to the in-development one.Closes #14528