added skip for ssr and non-browser environments#377
Conversation
✅ Deploy Preview for anchor-position-wpt canceled.
|
✅ Deploy Preview for anchor-polyfill ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jamesnw
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
|
The lint and test checks are stuck for some reason. It seems like the recommendation is to close the PR and re-open, so I'm going to try that. Apologies for the notification noise. |
|
It looks like the problem is |
|
@break-stuff It looks like it's still stalled out. I've opened #378 to track that issue. |
|
@jamesnw I may have found the issue. There are failing tests, but they are being masked by the script parallelization. I updated them to now stop when any of the scripts fail. I was able to find the tests that were failing and skipped them until further investigation. |
|
@jamesnw are you able to kick off CI actions again? |
|
It's currently hanging, and I'm pretty sure it did run last week . I'm grateful for your help troubleshooting the workflow, but I wonder about keeping that investigation separate from this PR. I'll ask some questions I have about the proposed solution in #378. |
|
I reverted my previous changes. Tests are passing after updating to node v24.12.0. I left the |
|
Removed |
|
Thanks for your patience! |
|
Thank you, @jamesnw! I really appreciate your help! |
Description
This crashes in SSR environments (the popover polyfill works fine).
Related Issue(s)
Reminder to add related issue(s), if available.
Steps to test/reproduce
Importing directly from
@oddbird/css-anchor-positioningcrashes in SSR and JSDOM environments.We were able to get it working by importing the function and calling it, but it would be nice to have it behave consistently like the popover polyfill.
Show me
Provide screenshots/animated gifs/videos if necessary.