[FIX] l10n_es: asset model#4974
Open
danych2 wants to merge 2 commits into19.0-l10n_es-accounting-onboarding-malbfrom
Open
[FIX] l10n_es: asset model#4974danych2 wants to merge 2 commits into19.0-l10n_es-accounting-onboarding-malbfrom
danych2 wants to merge 2 commits into19.0-l10n_es-accounting-onboarding-malbfrom
Conversation
Add ES asset model task-5867650
|
This PR targets the un-managed branch odoo-dev/odoo:19.0-l10n_es-accounting-onboarding-malb, it needs to be retargeted before it can be merged. |
|
This PR targets the un-managed branch odoo-dev/odoo:19.0-l10n_es-accounting-onboarding-malb, it needs to be retargeted before it can be merged. |
FlorianGilbert
requested changes
Jan 27, 2026
FlorianGilbert
left a comment
FlorianGilbert
left a comment
There was a problem hiding this comment.
The spec is not correctly followed 😄
There was a problem hiding this comment.
The file is not following the spec, some accounts are in the wrong column, other are wrong.
Author
There was a problem hiding this comment.
ugh, indeed, the dangers of trying to end something quickly right before going home 😅
FlorianGilbert
requested changes
Jan 30, 2026
| "asset_development","account_common_201","account_common_2800","account_common_680","Development","5","12" | ||
| "asset_adm_concessions","account_common_202","account_common_2800","account_common_682","Administrative concessions","5","12" | ||
| "asset_ind_property","account_common_203","account_common_2800","account_common_682","Industrial property","10","12" | ||
| "asset_goodwill","account_full_204","account_common_2800","account_common_682","Goodwill","10","12" |
There was a problem hiding this comment.
Ahah you didn't catch the trap 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ES asset model
task-5867650