Open
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding, it needs to be retargeted before it can be merged. |
This sets the "New Contract" button on the employee form invisible if the contract start date is not set. Task: 5900839
Problem --------- Error message when creating a new time off request and trying to change the time off type. Navigation: Time Off > Configuration > Time Off Types > Any time off type > Smart Button "Time Off" > New > Time Off Type Or Time Off > Management > Time Off > New > Time Off Type Objective ---------- When filtering for valid time off types, the comparison call requires two arguments (remaining leaves and amount requested), but only one was provided. Solution --------- Amended the function call to include the missing value for the requested amount of leaves, allowing valid leave types to be filtered. Task: 5905152
Problem ----------- When creating an accrual plan with yearly or twice yearly accrual frequency, days 1-31 are available for every month, so February 31 is a possible date to set. Objective ------------ The selection field does not filter the days based on the month that is selected, so all months allow days 1-31. Need to change the UI to only show valid days for each month. Solution ------------ - Created new component to filter day selection options based on the selected month - Edited the accrual views to use the widget - Created JS tour to test the widget Task: 5913447
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.