Conversation
|
|
sasri-odoo
force-pushed
the
19.0-tutorial-sasri
branch
from
1137d5e to
7076417
Compare
mash-odoo
left a comment
mash-odoo
left a comment
There was a problem hiding this comment.
Hello!
Thank you for your work!
Please revert the changes for awesome_owl , awesome_dashboard and website_airproof as of now
Here are some suggestions, mostly linter as of now!
Also, please update your PR title and description.
Furthermore, please update description in your commits while pushing, regarding the chapters and topics covered.
estate/models/estate_property.py
Outdated
| name = fields.Char() | ||
| description = fields.Text(required=True) | ||
| postcode = fields.Char() | ||
|
|
There was a problem hiding this comment.
Do not leave lines between fields
estate/models/estate_property.py
Outdated
| ("north", "North"), | ||
| ("south", "South"), | ||
| ("east", "East"), | ||
| ("west", "West"), |
There was a problem hiding this comment.
| ("north", "North"), | |
| ("south", "South"), | |
| ("east", "East"), | |
| ("west", "West"), | |
| ('north', "North"), | |
| ('south', "South"), | |
| ('east', "East"), | |
| ('west', "West"), |
try keeping the key in lower case
estate/security/ir.model.access.csv
Outdated
| access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1 | ||
| access_estate_property_type,access_estate_property_type,model_estate_property_type,base.group_user,1,1,1,1 | ||
| access_estate_property_tag,access_estate_property_tag,model_estate_property_tag,base.group_user,1,1,1,1 | ||
| access_estate_property_offer,access_estate_property_offer,model_estate_property_offer,base.group_user,1,1,1,1 No newline at end of file |
There was a problem hiding this comment.
Always add an extra line at the end of the file
estate/__manifest__.py
Outdated
| "depends": [ | ||
| "base", | ||
| ], |
There was a problem hiding this comment.
| "depends": [ | |
| "base", | |
| ], | |
| "depends": [ "base"], |
| <record id="estate_property_offer_list_view" model="ir.ui.view"> | ||
| <field name="name">estate.property.offer.list</field> |
There was a problem hiding this comment.
| <record id="estate_property_offer_list_view" model="ir.ui.view"> | |
| <field name="name">estate.property.offer.list</field> | |
| <record id="estate_property_offer_view_list" model="ir.ui.view"> | |
| <field name="name">estate.property.offer.view.list</field> |
For naming a view: <model_name>_view_<view_type>, where view_type is kanban, form, list, search, …
You can refer this guideline: https://www.odoo.com/documentation/19.0/contributing/development/coding_guidelines.html#xml-ids-and-naming
sasri-odoo
force-pushed
the
19.0-tutorial-sasri
branch
from
21bd5d1 to
77ec270
Compare
sasri-odoo
force-pushed
the
19.0-tutorial-sasri
branch
from
8831a1d to
87514d8
Compare
…adline, and garden onchange
3 participants
Implements Chapter 7 of the estate tutorial by introducing the property model, UI views, and relational fields using many2one, one2many, and many2many