Skip to content

ahham - Technical Training Estate module #1171

Open
ahmedhamila wants to merge 5 commits intoodoo:19.0from
odoo-dev:19.0-training-ahham
Open

ahham - Technical Training Estate module #1171
ahmedhamila wants to merge 5 commits intoodoo:19.0from
odoo-dev:19.0-training-ahham

Conversation

@ahmedhamila
Copy link

No description provided.

@robodoo
Copy link

robodoo commented Feb 16, 2026

Pull request status dashboard

@ahmedhamila ahmedhamila changed the title Technical Training Estate module ahham - Technical Training Estate module Feb 16, 2026
Copy link

@ltinel ltinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, almost nothing to say 🙂

'data': [
'security/ir.model.access.csv',
],
'installable': True,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I believe this is the default, so you don't strictly need to specify it.

],
'installable': True,
'application': True,
'author': 'ahham',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, we put Odoo S.A. here, but it doesn't matter much in this context :)

@ltinel
Copy link

ltinel commented Feb 16, 2026

@ahmedhamila Regarding your commits:

  • Could you create one commit per chapter (no need for a FIX commit, you can just squash the fix with the "main" commit).
  • FIX commits are for bug fixes, not linting and formatting (See [1]). You can use CLN or LINT for those (but squashing the commits is better in this case).
  • Could you use imperative style for the first line of your commit message? I.e. "add" instead of "added".
  • The module name (following [ADD]) can be lower case.

[1] https://www.odoo.com/documentation/master/contributing/development/git_guidelines.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants