luleg - Technical Training - Creation of the Real Estate Module#1176
Open
luleg - Technical Training - Creation of the Real Estate Module#1176
Conversation
|
|
AlessandroLupo
left a comment
AlessandroLupo
left a comment
There was a problem hiding this comment.
Nice work! 👍
Ideally, we should have a single commit per tutorial chapter. But I see that you introduced some code in advance (for example, EstateTagCategory is introduced in chapter 7, right?). Is there a specific reason for this? As a git exercise, you could try to move some of this content to the right commit when you reach the correct chapter.
It is very good that you fixed the styling error. You could try to do it in the already existing commits instead of adding a new one.
Depending on your confidence with git, this may be boring or may be very interesting. Feel free to ask for help if you need :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is my progress on the Technical training
Don't hesitate to give me feedbacks about what I could improve.