[IMP] modules: skip autoinstall of unintalled modules #367
+61
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
Contributor
Author
|
upgradeci retry with only base iap_mail |
jjmaksoud
force-pushed
the
master-skip-autoinstall-removed-modules-maji
branch
from
aec1a38 to
7464dda
Compare
Contributor
Author
|
upgradeci retry with always only base iap_mail |
jjmaksoud
force-pushed
the
master-skip-autoinstall-removed-modules-maji
branch
from
7464dda to
4c2b786
Compare
aj-fuentes
reviewed
Dec 9, 2025
Contributor
aj-fuentes
left a comment
aj-fuentes
left a comment
There was a problem hiding this comment.
A first quick pass, some nits to keep the diff to the point :)
I will experiment with this a bit soon. Thanks!
Contributor
jjmaksoud
force-pushed
the
master-skip-autoinstall-removed-modules-maji
branch
from
4c2b786 to
64feb35
Compare
KangOl
reviewed
Dec 9, 2025
jjmaksoud
force-pushed
the
master-skip-autoinstall-removed-modules-maji
branch
from
64feb35 to
888f583
Compare
cawo-odoo
reviewed
Dec 9, 2025
jjmaksoud
commented
Dec 9, 2025
| _assert_modules_exists(cr, module) | ||
| to_autoinstall = _get_autoinstallable_modules(cr, module) | ||
| if to_autoinstall: | ||
| if module in ENVIRON["__modules_to_skip_autoinstall"]: |
Contributor
Author
There was a problem hiding this comment.
This at the moment is not doing anything because the method trigger_auto_install is only called in the context of new_module and in some pre scripts also for new modules. But it does not hurt to keep it just in case, as the method can be called elsewhere
jjmaksoud
force-pushed
the
master-skip-autoinstall-removed-modules-maji
branch
from
888f583 to
005e6a3
Compare
aj-fuentes
reviewed
Dec 9, 2025
src/util/modules.py
Outdated
Comment on lines
736
to
737
| "Skipping the auto installation of module %r despite having all its auto install dependencies installed " | ||
| "by the force install of %r, because it was previously uninstalled." |
Contributor
There was a problem hiding this comment.
We should make this more direct:
Suggested change
| "Skipping the auto installation of module %r despite having all its auto install dependencies installed " | |
| "by the force install of %r, because it was previously uninstalled." | |
| "Module %r won't be auto installed because its original dependencies were already installed. " | |
| "Yet all its auto install dependencies were installed by the force install of {!r}." |
- First we tell what we skip and why: no module installed
- Then we we tell how we reached this point: as a result of an install of another module.
Both details are highly useful when debugging auto-install issues.
Contributor
Author
There was a problem hiding this comment.
updated, still not the smoothest sentence but it's for our own info anyway
In the case where an autoninstall module is uninstalled by users prior to the upgrade start, this module could be reinstalled during the upgrade if there were dependency changes and those dependencies get force installed. This improvement keeps track of any module that was elligible for autoinstall before the upgrade starts and skips its force installation when dependencies change.
jjmaksoud
force-pushed
the
master-skip-autoinstall-removed-modules-maji
branch
from
005e6a3 to
f319738
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case where an autoninstall module is uninstalled by users prior to the upgrade start, this module could be reinstalled during the upgrade if there were dependency changes and those dependencies get force installed. This improvement keeps track of any module that was illegible for autoinstall before the upgrade starts and skips its force installation when dependencies change.