refactor: simplify Inspector architecture#33
Merged
Conversation
…Target
Remove DashboardDetailTarget discriminated union, toDetailTarget boilerplate,
and centralized use-entity-action-handler. Inspectors now receive only itemKey,
fetch their own data via cached queries, and handle actions internally.
Selection state simplified to { type, key }. Added InspectorSkeleton for
loading states and lastSelected ref to preserve content during Sheet close
animation.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…l status logic Inspector components (agent, mcp, skill) now fall back to plugin contents when item is not found in standalone queries. Extract resolveInstallStatus as a pure utility with comprehensive tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- HooksPanel: iterate groups instead of flat allHooks to preserve matcher in key generation (matches hookConfig.getKey canonical format) - PluginsPanel: include matcher + command in hook key (was only scope:event) - McpInspector: invalidate mcpServers.all instead of agentFiles.all on delete - Update DESIGN-SYSTEM.md with InspectorSkeleton, InspectorActions, Inspector pattern section, and remove DashboardDetailTarget references - Add Hook Key rules to CONVENTIONS.md Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DashboardDetailTargetdiscriminated union andtoDetailTargetboilerplate from EntityConfiguse-entity-action-handler.ts— each Inspector now handles its own actions internallyitemKeyprop, fetch data via cached React Query hooks{ type: string; key: string }InspectorSkeletonprimitive for loading stateslastSelectedrefTest plan
pnpm typecheck && pnpm lint && pnpm testpasses🤖 Generated with Claude Code