Conversation
…tory (#38) Move remaining 4 entity domains (mcp, plugin, file, memory) to src/features/ completing the co-located feature directory pattern for all 7 domains (hook, skill, subagent already migrated). Each domain now follows the standard structure: src/features/{domain}/ config.ts, service.ts, server.ts, queries.ts, utils.ts/constants.ts, components/, *.test.ts Removed scattered files from services/, server/, hooks/, lib/, components/, config/entities/. Updated ~50 import references across the codebase. Added 16 integration tests for migration integrity and restored 19 getPluginMcpServers unit tests. Constraint: shared files (entity-inspector, entities/index, BoardLayout) updated in separate phase to avoid parallel agent conflicts Rejected: separate worktrees per domain | shared file merge conflicts outweigh isolation benefit Confidence: high Scope-risk: broad Not-tested: runtime UI rendering (only static imports and unit tests verified) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove 6 re-export files that only forwarded imports:
- files-editor/api/files.{queries,functions}.ts
- files-editor/constants.ts
- config-editor/api/config.{queries,functions}.ts
- config-editor/constants.ts
Strip barrel exports from config/entities/index.ts (keep
registration side-effect only). Update 7 consumer files to
import directly from source modules.
Delete feature-migration.test.ts (export existence checks
are not meaningful integration tests).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ohing504
force-pushed
the
refactor/migrate-remaining-domains-to-features
branch
from
8ee8a86 to
6176010
Compare
mcp/service.test.ts and plugin/service.test.ts use real filesystem (createTmpDir/removeTmpDir), making them integration tests per TESTING.md rules. Move from co-located src/features/ to tests/integration/ where they belong. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Now that the integration test moved to tests/integration/, the co-located unit test can use the standard service.test.ts name matching its test target (mcp/service.ts). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/features/로 이관하여 전체 7개 엔티티 도메인의 co-located feature directory 패턴 완성getPluginMcpServers단위 테스트 19개 복원Changes
Test plan
pnpm typecheck— 0 errorspnpm lint— cleanpnpm test— 336 tests, 33 files, all passed🤖 Generated with Claude Code