Skip to content

Ensure non-person kennitala is valid even though its corresponding da… #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sodds wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ensure non-person kennitala is valid even though its corresponding da… #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions kennitala/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,11 @@ def validate(self):

try:
date(year, month, day)
except ValueError:
if int(kennitala[0]) <= 3 or 1 > day > 31:
return False

try:
checkdigit = Kennitala._compute_checkdigit(kennitala)
return kennitala[-2] == checkdigit
except ValueError:
Expand Down
1 change: 1 addition & 0 deletions tests/test_kennitala.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
'140543-3229', # kennitala of Icelandic president
'1203753509', # kennitala of Icelandic prime minister
'6503760649', # kennitala of Þjóðskrá Íslands (Registry Iceland)
'7102692709', # kennitala of Þjóðleikhúsið (National Theatre)
)

birth_dates = (date(1943, 5, 14), date(1975, 3, 12))
Expand Down