feat: adds angular 19 and standalone support#170
feat: adds angular 19 and standalone support#170jaredperreault-okta wants to merge 2 commits intomasterfrom
Conversation
|
Hi @n-elhk! I saw you created a PR trying to make changes like this in the SDK. Are you interested in taking a look and offering feedback? 😀 Thanks for your consideration! |
|
I reviewed the MR, and it looks good to me. Nice work ! Just a small comment: maybe you could replace the ngDestroy usages with DestroyRef and onDestroy. What do you think ? |
|
@n-elhk Thanks for the quick review! I'm on board with using the DestroyRef, thanks for the suggestion. I incorporated it here if you want to take a peek @jaredperreault-okta would you mind adding this commit to this PR, please? I ran the build locally, including the CI scripts, but I'm sure you'll want to double check. in addition to the destroyRef changes I suppressed the cjs warning i'm still seeing. 😄 Thanks! |
Adds support for Angular 19+ and Standalone architecture