Skip to content

feat: adds angular 19 and standalone support#170

Open
jaredperreault-okta wants to merge 2 commits intomasterfrom
jp-pub-pr-167
Open

feat: adds angular 19 and standalone support#170
jaredperreault-okta wants to merge 2 commits intomasterfrom
jp-pub-pr-167

Conversation

@jaredperreault-okta
Copy link
Copy Markdown
Contributor

@jaredperreault-okta jaredperreault-okta commented May 5, 2026

Adds support for Angular 19+ and Standalone architecture

Copy link
Copy Markdown

@alisaduncan alisaduncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍠

@alisaduncan
Copy link
Copy Markdown

Hi @n-elhk!

I saw you created a PR trying to make changes like this in the SDK. Are you interested in taking a look and offering feedback? 😀

Thanks for your consideration!

@n-elhk
Copy link
Copy Markdown

n-elhk commented May 6, 2026

I reviewed the MR, and it looks good to me. Nice work !

Just a small comment: maybe you could replace the ngDestroy usages with DestroyRef and onDestroy. What do you think ?

@alisaduncan
Copy link
Copy Markdown

alisaduncan commented May 6, 2026

@n-elhk Thanks for the quick review! I'm on board with using the DestroyRef, thanks for the suggestion.

I incorporated it here if you want to take a peek

1bbdebd

@jaredperreault-okta would you mind adding this commit to this PR, please? I ran the build locally, including the CI scripts, but I'm sure you'll want to double check. in addition to the destroyRef changes I suppressed the cjs warning i'm still seeing. 😄 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants