Disable unicode_strings when working with regular expressions#37
Open
ppisar wants to merge 1 commit intooliwer:masterfrom
Open
Disable unicode_strings when working with regular expressions#37ppisar wants to merge 1 commit intooliwer:masterfrom
ppisar wants to merge 1 commit intooliwer:masterfrom
Conversation
Mojo::Base 0.50 enables unicode_strings feature in the scope where it used from. As a result, deserializing a regular expression injects qr//u flag to regexp object although the was no such flags in the deserialized BSON. The same issue repeats in t/bson.t when shuffling with the regular expressions. The consequence is that a t/bson.t test fails. This patch fixes it with disabling unicode_strings feature where needed. oliwer#36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mojo::Base 0.50 enables unicode_strings feature in the scope where it
used from. As a result, deserializing a regular expression injects
qr//u flag to regexp object although the was no such flags in the
deserialized BSON. The same issue repeats in t/bson.t when shuffling
with the regular expressions.
The consequence is that a t/bson.t test fails.
This patch fixes it with disabling unicode_strings feature where
needed.
#36