Skip to content

Replace arrayCoordinateSystem with explanation on how to express dimensionless transforms in pixel coordinates#118

Open
jo-mueller wants to merge 11 commits intoome:mainfrom
jo-mueller:no-array-cs
Open

Replace arrayCoordinateSystem with explanation on how to express dimensionless transforms in pixel coordinates#118
jo-mueller wants to merge 11 commits intoome:mainfrom
jo-mueller:no-array-cs

Conversation

@jo-mueller
Copy link
Copy Markdown
Contributor

Fixes ome/ngff#438
Addresses comment 4 on RFC5.

Title. This PR replaces the definition of implicit arrayCoordinateSystems with examples and explanatory text on how to properly express transforms that are done in pixel space, not unit space.

Follow up PR to #103 and #90

cc @bogovicj @btbest @will-moore @clbarnes @dstansby

@jo-mueller jo-mueller added the enhancement New feature or request label Mar 26, 2026
@github-actions
Copy link
Copy Markdown

Automated Review URLs

Comment thread index.md Outdated
Comment thread index.md Outdated
@btbest
Copy link
Copy Markdown
Contributor

btbest commented Mar 27, 2026

Perfect from my point of view! 🚀

Comment thread index.md Outdated
@jo-mueller jo-mueller marked this pull request as ready for review March 27, 2026 07:44
Comment thread index.md Outdated
Comment thread index.md
Comment thread index.md
Comment thread index.md Outdated
Comment thread index.md Outdated
@will-moore will-moore mentioned this pull request Apr 1, 2026
Copy link
Copy Markdown
Contributor

@bogovicj bogovicj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this PR's scope as being pretty small, it does what it says and is clear (modulo the discussion below). So I approve these changes.

There are comments here about definitions and terminology that deserve further discussion. @d-v-b opened this issue ome/ngff#492
and I suggest we move the discussion there.

It's true that the phrasing of the examples and text edited here will change as a result of those decisions we'll have about terminology, but they'll affect more than what is written here, so I'd suggest those larger changes be a separate PR.

@jo-mueller jo-mueller requested review from d-v-b and will-moore April 8, 2026 18:06
@jo-mueller jo-mueller requested a review from bogovicj April 8, 2026 18:06
Copy link
Copy Markdown
Member

@will-moore will-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never really felt the need for Array coordinate systems, so it almost feels a bit verbose to describe how to work without them. But no objections if it's useful, Thanks

@jo-mueller
Copy link
Copy Markdown
Contributor Author

so it almost feels a bit verbose to describe how to work without them. But no objections if it's useful

Yeah...maybe we'll need a section for "How to express this or that data structure" to be broken out of the spec at some point 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC5 - explain usage of arraycoordinatesystems arrayCoordinateSystem

9 participants