Skip to content

Fix test cases in v0.5#124

Open
clbarnes wants to merge 5 commits intoome:0.5from
clbarnes:0.5-325-fixtests
Open

Fix test cases in v0.5#124
clbarnes wants to merge 5 commits intoome:0.5from
clbarnes:0.5-325-fixtests

Conversation

@clbarnes
Copy link
Copy Markdown
Contributor

@clbarnes clbarnes commented Apr 2, 2026

Fixes the test cases listed in ome/ngff#325

See #325
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

Automated Review URLs

@clbarnes clbarnes changed the base branch from main to 0.5 April 2, 2026 13:57
@clbarnes clbarnes changed the title 0.5 325 fixtests Fix test cases in v0.5 Apr 2, 2026
@clbarnes
Copy link
Copy Markdown
Contributor Author

clbarnes commented Apr 2, 2026

The failing test is somewhat subjective, about the image label's color JSON array. The spec says "this contains one entry per label", which is probably a MUST. If the label zarr array were zero-size, the color JSON array could strictly be empty and valid, although that's obviously a pathological case. I'm OK with reverting this test to empty color arrays as invalid.

@clbarnes clbarnes requested a review from jo-mueller April 9, 2026 11:11
@clbarnes
Copy link
Copy Markdown
Contributor Author

clbarnes commented Apr 9, 2026

If this is acceptable I'll make the same changes to the previous and future versions.

Comment thread tests/plate_suite.json Outdated
@jo-mueller
Copy link
Copy Markdown
Contributor

LGTM 👍

@lubianat
Copy link
Copy Markdown
Contributor

think the fixes are good, but I wonder if we could drop updates for some of the older versions, if only to reduce the noise here and in the dependabot PRs

Following the lead on ome-zarr-py, maybe we don't propagate this (and similar) changes for ≤ 0.3?

Not sure on the correct protocol here, though

@lubianat lubianat added the bug Something isn't working label Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants