Conversation
Automated Review URLs |
|
The failing test is somewhat subjective, about the image label's color JSON array. The spec says "this contains one entry per label", which is probably a MUST. If the label zarr array were zero-size, the color JSON array could strictly be empty and valid, although that's obviously a pathological case. I'm OK with reverting this test to empty color arrays as invalid. |
|
If this is acceptable I'll make the same changes to the previous and future versions. |
|
LGTM 👍 |
|
think the fixes are good, but I wonder if we could drop updates for some of the older versions, if only to reduce the noise here and in the dependabot PRs Following the lead on ome-zarr-py, maybe we don't propagate this (and similar) changes for ≤ 0.3? Not sure on the correct protocol here, though |
Fixes the test cases listed in ome/ngff#325