Skip to content

[MIT-3594] Sunset Internet Banking#228

Merged
rosle merged 1 commit intomasterfrom
MIT-3594-sunset-internet-banking
Mar 20, 2026
Merged

[MIT-3594] Sunset Internet Banking#228
rosle merged 1 commit intomasterfrom
MIT-3594-sunset-internet-banking

Conversation

@rosle
Copy link
Contributor

@rosle rosle commented Mar 12, 2026

Description

Remove Internet Banking related code from the codebase. Here we're removing/replacing the internet banking method in the tests.

Related links:

Rollback procedure

default rollback procedure

@rosle rosle self-assigned this Mar 12, 2026
@rosle rosle requested a review from Copilot March 13, 2026 02:20
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes remaining Internet Banking references from tests, mocks, and example source/charge creation flows as part of sunsetting Internet Banking support.

Changes:

  • Update source creation/retrieval test data and mocks from internet_banking_bbl to mobile_banking_bbl (and flow to app_redirect).
  • Remove internet_banking_* entries from the capability retrieval mock.
  • Update JS/TS examples to create a non–Internet Banking source (promptpay) for the source-charge example.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/test_omise_source.js Switches the test source type away from Internet Banking.
test/mocks/sources_retrieve.js Updates mocked retrieved source to mobile_banking_bbl and app_redirect flow.
test/mocks/sources_create.js Updates mocked created source to mobile_banking_bbl and app_redirect flow.
test/mocks/capability_retrieve.js Removes Internet Banking payment methods from mocked capabilities response.
examples/typescript/src/create_source_charge.ts Updates example source type to promptpay (non–Internet Banking).
examples/javascript/create_source_charge.js Updates example source type to promptpay (non–Internet Banking).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@rosle rosle marked this pull request as ready for review March 13, 2026 02:25
@rosle rosle merged commit 8ec386a into master Mar 20, 2026
14 checks passed
@rosle rosle deleted the MIT-3594-sunset-internet-banking branch March 20, 2026 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants