Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Removes remaining Internet Banking references from tests, mocks, and example source/charge creation flows as part of sunsetting Internet Banking support.
Changes:
- Update source creation/retrieval test data and mocks from
internet_banking_bbltomobile_banking_bbl(andflowtoapp_redirect). - Remove
internet_banking_*entries from the capability retrieval mock. - Update JS/TS examples to create a non–Internet Banking source (
promptpay) for the source-charge example.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/test_omise_source.js | Switches the test source type away from Internet Banking. |
| test/mocks/sources_retrieve.js | Updates mocked retrieved source to mobile_banking_bbl and app_redirect flow. |
| test/mocks/sources_create.js | Updates mocked created source to mobile_banking_bbl and app_redirect flow. |
| test/mocks/capability_retrieve.js | Removes Internet Banking payment methods from mocked capabilities response. |
| examples/typescript/src/create_source_charge.ts | Updates example source type to promptpay (non–Internet Banking). |
| examples/javascript/create_source_charge.js | Updates example source type to promptpay (non–Internet Banking). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
new4762
approved these changes
Mar 19, 2026
AnasNaouchi
approved these changes
Mar 19, 2026
Narum11
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove Internet Banking related code from the codebase. Here we're removing/replacing the internet banking method in the tests.
Related links:
Rollback procedure
default rollback procedure