Refactor Ethereum txId logic and update tests #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standardizes Ethereum transaction hash calculation to use keccak256 of the signed/encoded transaction, removing previous logic that returned preHash. Updates related Android and iOS tests and wallet code to match this behavior, clarifies distinction between signing hash and transaction hash, and improves cache deserialization robustness.
PR SummaryStandardized Ethereum transaction hash calculation to use keccak256 of the signed/encoded transaction instead of returning Changes
autogenerated by presubmit.ai |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (1)
- 59b4bcd: Refactor Ethereum txId logic and update tests
Standardizes Ethereum transaction hash calculation to use keccak256 of the signed/encoded transaction, removing previous logic that returned preHash. Updates related Android and iOS tests and wallet code to match this behavior, clarifies distinction between signing hash and transaction hash, and improves cache deserialization robustness.
Files Processed (11)
- Android/wallet/src/androidTest/java/com/flow/wallet/keys/EthereumKeyTests.kt (1 hunk)
- Android/wallet/src/androidTest/java/com/flow/wallet/keys/SeedPhraseKeyProviderTest.kt (1 hunk)
- Android/wallet/src/androidTest/java/com/flow/wallet/wallet/EthereumWalletTests.kt (4 hunks)
- Android/wallet/src/androidTest/java/com/flow/wallet/wallet/WalletInstrumentedTest.kt (2 hunks)
- Android/wallet/src/main/java/com/flow/wallet/keys/SeedPhraseKey.kt (6 hunks)
- Android/wallet/src/main/java/com/flow/wallet/storage/Cacheable.kt (4 hunks)
- Android/wallet/src/main/java/com/flow/wallet/wallet/EthereumSigningOutputExtensions.kt (1 hunk)
- Android/wallet/src/test/java/com/flow/wallet/keys/SeedPhraseKeyProviderTest.kt (1 hunk)
- iOS/FlowWalletKit/Sources/Wallet/EthereumSigningOutput+TxID.swift (2 hunks)
- iOS/FlowWalletKit/Sources/Wallet/Wallet+EOA.swift (1 hunk)
- iOS/FlowWalletKit/Tests/FlowWalletKitTests/EOATests.swift (2 hunks)
Actionable Comments (1)
-
Android/wallet/src/androidTest/java/com/flow/wallet/wallet/WalletInstrumentedTest.kt [54-55]
possible bug: "TODO implementation returns invalid data"
Skipped Comments (3)
-
Android/wallet/src/androidTest/java/com/flow/wallet/wallet/WalletInstrumentedTest.kt [56-57]
possible issue: "Unreachable code after TODO exception"
-
Android/wallet/src/main/java/com/flow/wallet/keys/SeedPhraseKey.kt [270-278]
maintainability: "Unused method with hardcoded values"
-
iOS/FlowWalletKit/Tests/FlowWalletKitTests/EOATests.swift [165-165]
maintainability: "Hardcoded private key lacks documentation"
Comment on lines
+54
to
+55
| return ByteArray(1) | ||
| } |
There was a problem hiding this comment.
The TODO implementation should not return a hardcoded ByteArray(1). This could cause runtime issues if this method is actually called during testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardizes Ethereum transaction hash calculation to use keccak256 of the signed/encoded transaction, removing previous logic that returned preHash. Updates related Android and iOS tests and wallet code to match this behavior, clarifies distinction between signing hash and transaction hash, and improves cache deserialization robustness.