Skip to content

FLOW-8: Implement minimal YieldVault views#158

Open
liobrasil wants to merge 1 commit intomainfrom
fix/FLOW-8-view-resolver-implementation
Open

FLOW-8: Implement minimal YieldVault views#158
liobrasil wants to merge 1 commit intomainfrom
fix/FLOW-8-view-resolver-implementation

Conversation

@liobrasil
Copy link
Contributor

Closes: #139

Description

Implements minimal ViewResolver.Resolver views for FlowYieldVaults.YieldVault so the type no longer advertises view support while returning empty data.

  • Adds YieldVaultInfo and YieldVaultBalance view structs.
  • Implements YieldVault.getViews() and YieldVault.resolveView(_:) for both views.
  • Fixes YieldVault.getStrategyType() to return the concrete (non-optional) type identifier.
  • Adds scripts + regression coverage validating both views resolve for a live YieldVault.

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@liobrasil liobrasil requested a review from a team as a code owner February 2, 2026 21:45
@liobrasil liobrasil added bug Something isn't working QS FYV Audit First Round ⎈ QuantStamp This issue is related to QuantStamp review comment labels Feb 2, 2026
@liobrasil liobrasil requested review from nialexsan and nvdtf February 2, 2026 21:48

/// YieldVaultBalance
///
/// Minimal view struct providing the YieldVault's current available balance for the vault's denomination. ///
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Minimal view struct providing the YieldVault's current available balance for the vault's denomination. ///
/// Minimal view struct providing the YieldVault's current available balance for the vault's denomination.

Copy link
Collaborator

@m-Peter m-Peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working QS FYV Audit First Round ⎈ QuantStamp This issue is related to QuantStamp review comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FLOW-8 Incomplete ViewResolver implementation on YieldVault

2 participants