Skip to content

Conversation

@janezpodhostnik
Copy link
Contributor

Closes #???

Description

There is a bunch of old/redundant stuff in the makefile:

  • mockery not actually used in this repo
  • creating coverage.zip and sanderhahn/gozip old TeamCity relic. No longer used
  • GOPRIVATE not used. (relic from when we had the flow-go repo in dapperlabs
  • UNAME not used
  • GOPATH and PATH not used. this is less obvious... CI could be using it (but its not). users might need this, but that would point to a incorrect local installation of go.

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@github-actions
Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants