Skip to content

feat: make context provider compatible more modals (ie gluestack)#177

Open
jsg2021 wants to merge 1 commit intoonmotion:mainfrom
jsg2021:patch-1
Open

feat: make context provider compatible more modals (ie gluestack)#177
jsg2021 wants to merge 1 commit intoonmotion:mainfrom
jsg2021:patch-1

Conversation

@jsg2021
Copy link

@jsg2021 jsg2021 commented Feb 14, 2026

This change moves the children out of the backdrop view and makes the backdrop not contribute to layout.

Libraries like Gluestack would break if the context provider altered the children's parent/layout.

<Modal isOpen={open} onClose={requestClose} size="md">
	<AutocompleteDropdownContextProvider> {/* < --- this will break the modal if not updated  */}
		<ModalBackdrop />
		<ModalContent>
			<ModalHeader>
				<Heading size="lg">Modal Header</Heading>
				<ModalCloseButton>
					<Icon as={CloseIcon} />
				</ModalCloseButton>
			</ModalHeader>
			<ModalBody>
				<AutocompleteDropdown .../>
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant