Skip to content

feat: support all native div props on Scrollable #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aarush130 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: support all native div props on Scrollable #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/components/Scrollable/Scrollable.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,14 +173,15 @@ export default class Scrollable extends React.PureComponent {
}

render() {
const {children, style, element} = this.props;
// eslint-disable-next-line no-unused-vars
const {children, style, element, onScroll, onUpdate, scrollOnDOMChange, cssVarsOnTracks, className, ...rest} = this.props;
const vsb = findChildByType(children, VerticalScrollbarPlaceholder);
const hsb = findChildByType(children, HorizontalScrollbarPlaceholder);
const content = React.Children.toArray(children).filter(child => ![VerticalScrollbarPlaceholder, HorizontalScrollbarPlaceholder].includes(child.type));

return (
<ResizeObserver onResize={this.updateScrollbars}>
<div className='scrollbar' style={style} onTransitionEnd={this.handleOnTransitionEnd}>
<div {...rest} className={classNames('scrollbar', className)} style={style} onTransitionEnd={this.handleOnTransitionEnd}>
{React.cloneElement(element, this.getElementProps(), content)}
<Context.Provider value={this.state}>
{vsb ? vsb.props.children : <VerticalScrollbar/>}
Expand Down