Skip to content

fix: fixing null pointer exception error #1709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ayushman-Gaur wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: fixing null pointer exception error #1709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3abbfbc
fixing null pointer exception error
Ayushman-Gaur Mar 6, 2026
bd86aad
fix: update null check handling
Ayushman-Gaur Mar 6, 2026
c32e838
Fix null error
Ayushman-Gaur Mar 6, 2026
fbbb123
fix: apply spotless formatting
Ayushman-Gaur Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions tools/flagd-core/src/main/java/dev/openfeature/contrib/tools/flagd/core/FlagdCore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,11 +269,14 @@ private <T> ProviderEvaluation<T> resolve(Class<T> type, String key, EvaluationC

private static ImmutableMetadata getFlagMetadata(Map<String, Object> currentFlagSetMetadata, FeatureFlag flag) {
ImmutableMetadata.ImmutableMetadataBuilder metadataBuilder = ImmutableMetadata.builder();
for (Map.Entry<String, Object> entry : currentFlagSetMetadata.entrySet()) {
addEntryToMetadataBuilder(metadataBuilder, entry.getKey(), entry.getValue());

if (currentFlagSetMetadata != null) {
for (Map.Entry<String, Object> entry : currentFlagSetMetadata.entrySet()) {
addEntryToMetadataBuilder(metadataBuilder, entry.getKey(), entry.getValue());
}
}

if (flag != null) {
if (flag != null && flag.getMetadata() != null) {
for (Map.Entry<String, Object> entry : flag.getMetadata().entrySet()) {
addEntryToMetadataBuilder(metadataBuilder, entry.getKey(), entry.getValue());
}
Expand Down
22 changes: 22 additions & 0 deletions tools/flagd-core/src/test/java/dev/openfeature/contrib/tools/flagd/core/FlagdCoreTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package dev.openfeature.contrib.tools.flagd.core;

import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatNoException;

import dev.openfeature.contrib.tools.flagd.api.FlagStoreException;
import dev.openfeature.sdk.ImmutableContext;
Expand Down Expand Up @@ -124,4 +125,25 @@ void setFlagsAndGetChangedKeys_detectsRemovedFlags() throws FlagStoreException {
// Then: boolFlag should be in the changed keys (it was removed)
assertThat(changedKeys).contains("boolFlag");
}

@Test
void resolveBooleanValue_flagWithNullMetadata_doesNotThrowNPE() {
String configWithNullMetadata = "{"
+ "\"$schema\": \"https://flagd.dev/schema/v0/flags.json\","
+ "\"flags\": {"
+ " \"nullMetadataFlag\": {"
+ " \"state\": \"ENABLED\","
+ " \"defaultVariant\": \"on\","
+ " \"variants\": { \"on\": true }"
+ " }"
+ "}"
+ "}";

assertThatNoException().isThrownBy(() -> {
flagdCore.setFlags(configWithNullMetadata);
ProviderEvaluation<Boolean> result =
flagdCore.resolveBooleanValue("nullMetadataFlag", new ImmutableContext());
assertThat(result.getFlagMetadata()).isNotNull();
});
}
}
Loading