Issue1485 heat pump pressure drop#1487
Open
jelgerjansen wants to merge 35 commits into
Open
Conversation
…d other components.
…e used in the default formulation of UALoss
… and update documentation and annotations.
…value (which had wrong units)
annadellisola
requested changes
Apr 30, 2026
Contributor
annadellisola
left a comment
annadellisola
left a comment
There was a problem hiding this comment.
Thank you @jelgerjansen for addressing the issue.
I only have minor text suggestions.
| annotation (Placement( | ||
| transformation(extent={{-120,-50},{-80,-10}}),iconTransformation(extent={{-110, | ||
| -10},{-90,10}}))); | ||
| Modelica.Blocks.Interfaces.RealInput TCondensor_in |
Contributor
There was a problem hiding this comment.
Suggested change
| Modelica.Blocks.Interfaces.RealInput TCondensor_in | |
| Modelica.Blocks.Interfaces.RealInput TCondensor_in | |
| "In-comming condensor temperature" |
| extent={{-10,-10},{10,10}}, | ||
| rotation=90, | ||
| origin={-50,-100}))); | ||
| Modelica.Blocks.Interfaces.RealInput m_flowCondensor |
Contributor
There was a problem hiding this comment.
Suggested change
| Modelica.Blocks.Interfaces.RealInput m_flowCondensor | |
| Modelica.Blocks.Interfaces.RealInput m_flowCondensor | |
| "Condenor mass-flow rate" |
| extent={{-10,-10},{10,10}}, | ||
| rotation=90, | ||
| origin={-20,-100}))); | ||
| Modelica.Blocks.Interfaces.RealInput TEvaporator |
Contributor
There was a problem hiding this comment.
Suggested change
| Modelica.Blocks.Interfaces.RealInput TEvaporator | |
| Modelica.Blocks.Interfaces.RealInput TEvaporator | |
| "Evaporator temperature" |
| annotation (Placement(transformation(extent={{-120,-20},{-80,20}}), iconTransformation(extent={{-10,-10},{10,10}}, | ||
| rotation=270, | ||
| origin={-80,100}))); | ||
| Modelica.Blocks.Interfaces.RealInput TEnvironment |
Contributor
There was a problem hiding this comment.
Suggested change
| Modelica.Blocks.Interfaces.RealInput TEnvironment | |
| Modelica.Blocks.Interfaces.RealInput TEnvironment | |
| "Temperature of environment for heat losses" |
| annotation (Placement( | ||
| transformation(extent={{-120,40},{-80,80}}), iconTransformation(extent={{-110,20}, | ||
| {-90,40}}))); | ||
| Modelica.Blocks.Interfaces.RealInput TCondensor_set |
Contributor
There was a problem hiding this comment.
Suggested change
| Modelica.Blocks.Interfaces.RealInput TCondensor_set | |
| Modelica.Blocks.Interfaces.RealInput TCondensor_set | |
| "Condensor temperature setpoint" |
Comment on lines
+286
to
+299
| Finally, the modulation is calculated based on the asked power and the max power at operating conditions: | ||
| <ul> | ||
| <li> | ||
| if <code>modulation_init < modulation_min</code>, the heat pump is OFF, modulation = 0. | ||
| </li> | ||
| <li> | ||
| if <code>modulation_init > 100%</code>, the modulation is 100% | ||
| </li> | ||
| <li> | ||
| if <code>modulation_init</code> between <code>modulation_min</code> and <code>modulation_start</code>: hysteresis for on/off cycling. | ||
| </li> | ||
| </ul> | ||
| </p> | ||
| <p> |
Contributor
There was a problem hiding this comment.
Suggested change
| Finally, the modulation is calculated based on the asked power and the max power at operating conditions: | |
| <ul> | |
| <li> | |
| if <code>modulation_init < modulation_min</code>, the heat pump is OFF, modulation = 0. | |
| </li> | |
| <li> | |
| if <code>modulation_init > 100%</code>, the modulation is 100% | |
| </li> | |
| <li> | |
| if <code>modulation_init</code> between <code>modulation_min</code> and <code>modulation_start</code>: hysteresis for on/off cycling. | |
| </li> | |
| </ul> | |
| </p> | |
| <p> | |
| Finally, the modulation is calculated based on the asked power and the maximum power at operating conditions. | |
| The initial modulation is computed as <code>modulation_init = QAsked / QMax · 100</code>. | |
| </p> | |
| <p> | |
| If <code>useMinMod = true</code>, the final modulation is multiplied by the on/off signal: | |
| </p> | |
| <ul> | |
| <li> | |
| if <code>modulation_init < modulation_min</code>, the heat pump is OFF and the modulation is 0. | |
| </li> | |
| <li> | |
| if <code>modulation_init > 100%</code>, the modulation is limited to 100%. | |
| </li> | |
| <li> | |
| if <code>modulation_init</code> is between <code>modulation_min</code> and <code>modulation_start</code>, a hysteresis is applied for on/off cycling. | |
| </li> | |
| </ul> | |
| <p> | |
| If <code>useMinMod = false</code>, the modulation is calculated directly from <code>modulation_init</code>. | |
| </p> | |
| <p> | |
| In both cases, the modulation is smoothly limited to a maximum of 100%. | |
| </p> | |
| <p> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #1485.