Stabilize complex attributes #7973
Conversation
trask
force-pushed
the
stabilize-complex-attributes-try-2
branch
from
3bc8e76 to
8c951bd
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7973 +/- ##
============================================
+ Coverage 90.15% 90.28% +0.12%
- Complexity 7476 7606 +130
============================================
Files 836 839 +3
Lines 22550 22798 +248
Branches 2224 2256 +32
============================================
+ Hits 20331 20584 +253
+ Misses 1515 1505 -10
- Partials 704 709 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
trask
force-pushed
the
stabilize-complex-attributes-try-2
branch
from
30fb180 to
0e2af07
Compare
trask
force-pushed
the
stabilize-complex-attributes-try-2
branch
4 times, most recently
from
55d9121 to
23f5d22
Compare
trask
force-pushed
the
stabilize-complex-attributes-try-2
branch
from
23f5d22 to
0e19885
Compare
There was a problem hiding this comment.
changes copy-pasted from ExtendedArrayBackedAttributes.java
There was a problem hiding this comment.
changes copy-pasted from ExtendedArrayBackedAttributesBuilder.java
There was a problem hiding this comment.
changes copy-pasted from ExtendedAttributeKey.java
There was a problem hiding this comment.
changes copy-pasted from ExtendedAttributes.java
There was a problem hiding this comment.
changes copy-pasted from ExtendedAttributesBuilder.java
| // TODO(jack-berg): Should this be a JSON encoding? | ||
| // TODO deprecate in favor of toString() or toProtoJson()? | ||
| String asString(); |
There was a problem hiding this comment.
open question (also could consider keeping asString() and having it emit proto json and removing toProtoJson())
| @Override | ||
| public Void getValue() { | ||
| return null; |
There was a problem hiding this comment.
need to mark this @Nullable or return some marker value (instead of using Void)
| .putTag("bytes", "\"AQID\"") | ||
| .putTag("map", "{\"nested\":\"value\"}") | ||
| .putTag("heterogeneousArray", "[\"string\",123]") | ||
| .putTag("empty", "null") |
There was a problem hiding this comment.
same questionable choices:
"\"AQID\""vs"AQID""null"vs""vs"{}"
|
|
||
| @Override | ||
| public String asString() { | ||
| return ""; |
There was a problem hiding this comment.
another option would be return the string "null"
| * @return a JSON encoding of this value | ||
| */ | ||
| default String toProtoJson() { | ||
| return "\"unimplemented\""; |
There was a problem hiding this comment.
alternatively could throw UnsupportedOperationException
1 participant
No description provided.