Skip to content

opentelemetry-sdk: fix a couple of unbound variables in tests #5063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xrmx merged 2 commits into from
Apr 10, 2026
+6 −0
Merged

opentelemetry-sdk: fix a couple of unbound variables in tests #5063

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c130d62
opentelemetry-sdk: fix a couple of unbound variables in tests
xrmx Apr 9, 2026
d2b523f
Merge branch 'main' into fix-unbound-variables-in-tests
xrmx Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions opentelemetry-sdk/tests/trace/test_trace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2231,6 +2231,7 @@ def test_parent_child_span_exception(self):
exception_type = exception.__class__.__name__
exception_message = exception.args[0]

child_span = None
try:
with tracer.start_as_current_span(
"parent",
Expand All @@ -2245,6 +2246,8 @@ def test_parent_child_span_exception(self):
except Exception: # pylint: disable=broad-exception-caught
pass

self.assertIsNotNone(child_span)

self.assertTrue(child_span.status.is_ok)
self.assertIsNone(child_span.status.description)
self.assertTupleEqual(child_span.events, ())
Expand Down Expand Up @@ -2275,6 +2278,7 @@ def test_child_parent_span_exception(self):

exception = Exception("exception")

child_span = None
try:
with tracer.start_as_current_span(
"parent",
Expand All @@ -2290,6 +2294,8 @@ def test_child_parent_span_exception(self):
except Exception: # pylint: disable=broad-exception-caught
pass

self.assertIsNotNone(child_span)

self.assertTrue(child_span.status.is_ok)
self.assertIsNone(child_span.status.description)
self.assertTupleEqual(child_span.events, ())
Expand Down
Loading