Prometheus exporter: Add default aggregation config option#5249
Open
ArthurSens wants to merge 2 commits into
Open
Prometheus exporter: Add default aggregation config option#5249ArthurSens wants to merge 2 commits into
ArthurSens wants to merge 2 commits into
Conversation
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Contributor
|
Thanks for opening this PR! Unfortunately, we already have an open PR that addresses this: #5117. |
Member
Author
|
Oh, nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
default_aggregationtoPrometheusMetricReader, allowing the Prometheus exporter to configure the MetricReader default aggregation as a function of instrument kind.This follows the Prometheus exporter spec section being stabilized in open-telemetry/opentelemetry-specification#5113.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
uv run tox -e py312-test-opentelemetry-exporter-prometheus -- exporter/opentelemetry-exporter-prometheus/tests/test_prometheus_exporter.py::TestPrometheusMetricReader::test_constructor_default_aggregationuv run ruff check exporter/opentelemetry-exporter-prometheus/src/opentelemetry/exporter/prometheus/__init__.py exporter/opentelemetry-exporter-prometheus/tests/test_prometheus_exporter.pyDoes This PR Require a Contrib Repo Change?
Checklist:
Disclaimer: This PR was assisted by LLMs